Fully cover WebAPI::Auth::OpenID #6773
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wabri
force-pushed
the
feat/178948/auth/openid
branch
from
5e6d07f to
b19042f
Compare
Wabri
commented
Sep 26, 2025
Wabri
force-pushed
the
feat/178948/auth/openid
branch
from
b19042f to
30e0ec8
Compare
Wabri
force-pushed
the
feat/178948/auth/openid
branch
from
30e0ec8 to
4c09f5e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6773 +/- ##
==========================================
+ Coverage 99.25% 99.26% +0.01%
==========================================
Files 402 402
Lines 41278 41275 -3
==========================================
+ Hits 40970 40972 +2
+ Misses 308 303 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perlpunk
requested changes
Sep 26, 2025
| log_error("Claiming OpenID identity for URL '$url' failed: " . $csr->err); | ||
| return; | ||
| } | ||
| !defined $claimed_id and do { log_error("Claiming OpenID identity for URL '$url' failed: " . $csr->err); return; }; |
There was a problem hiding this comment.
The return will only return from the do block and not from the subroutine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://progress.opensuse.org/issues/178948