Remove .install suffix for repo files on MicroOS-SelfInstall flavor #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tinawang123
commented
Dec 5, 2024
tinawang123
commented
- Related ticket: https://progress.opensuse.org/issues/170158
- Related PR: Need to switch to 'repo to be tested for next snapshot' os-autoinst-distri-opensuse#20748
|
Please adjust your commit message to be more specific. It reads like you would change all repo files :) |
tinawang123
force-pushed
the
rminstall
branch
from
d1ed020 to
ba0c896
Compare
tinawang123
changed the title
|
You only changed the PR title. However, I'm wondering whether this change actually is MicroOS-SelfInstall specific. Looking at the code I'm more under the impression that this will change more than that. The style check is also failing. |
|
It seemed tricky, so I tried to reproduce and apparently the fix was rather simple, so I submitted #280 , I guess this one can be closed. |
|
Close this PR, as only impact one job, I will update job settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.