Include livepatches variables in openqa.cmd #322
Conversation
|
need testing on obs. as is for now, it breaks the print_openqa.sh for t/obs |
|
This approach will schedule tests for livepatch packages which haven't been updated in the product increment. |
d3flex
force-pushed
the
try/investigate_possible_issue
branch
from
d01fe01 to
c995f33
Compare
|
Can you update the ticket reference? The use of |
d3flex
force-pushed
the
try/investigate_possible_issue
branch
from
c995f33 to
2a3ce59
Compare
this will make the for runs once, netherless if the |
In the ticket, you said that What am I missing? |
The base
You're missing that the repo contains everything that was already released. We don't want to test everything, we want to test only the packages that are new since the last product increment. |
Automate the livepatch isos posts. Due to the logic of the script generation this commit contains an injection of a for loop for all the livepatches which will be scrapped from test repository. - the loop always run even if no livepatches found. However it will only append to the isos posts the variable in the case that actually livepatch versions inclue in the array. The approach is just a bit dirty, as any other approach would require further and bigger changes. depends-on: https://gitlab.suse.de/openqa/openqa-trigger-from-ibs-plugin/-/merge_requests/263 issue: https://progress.opensuse.org/issues/190134 Signed-off-by: Ioannis Bonatakis <[email protected]>
d3flex
force-pushed
the
try/investigate_possible_issue
branch
from
2a3ce59 to
f3db332
Compare
There was a problem hiding this comment.
I guess the idea isn't that bad in general. I guess it'll only ever return the latest livepatch, though (unless I'm misreading the code). It would maybe make more sense to return all livepatches that are newer than the creation date of the increment (as an increment can probably contain multiple livepatches and we want all of them and not just the latest).
| def openqa_fetch_livepatch_list(): | ||
| kpatches = {} | ||
| for arch in ['x86_64','aarch64','s390x','ppc64le']: | ||
| totest_url = f"https://download.suse.de/ibs/SUSE:/ALP:/Products:/Marble:/6.0:/ToTest/product/repo/SL-Micro-6.0-{arch}/{arch}/" |
There was a problem hiding this comment.
You can append ?jsontable to that URL and parse the JSON (instead of having to parse HTML with BeautifulSoup).
|
|
||
| # def pre_openqa_call_find_kernel_livepatch_versions(): | ||
| # return f"($(grep -oP '(?<=kernel-livepatch-)\d+_\d+_\d+-\d+' \"/var/lib/openqa/factory/iso/${{iso}}\" | uniq))" | ||
| def _find_latest_livepatches(url): |
There was a problem hiding this comment.
It would probably make sense to be able to execute this standalone (in the absence of unit tests, so it can at least be tested easily manually).
Automate the livepatch isos posts. Due to the logic of the script generation this commit contains an injection of a for loop for all the livepatches which will be found in the spdx.json, after the sync in the server.
rsync_isoafter all the necessary variables are set and before the beginning writing to the print_openqa.sh. At that point thespdx.jsonshould be available and it needs only to grep for the kernel_livepatch in the server. Before that point, the scriptgen.py would have to make a request to each repo in the dist.s.d and it is likely it would be less flexible as the logic of the isos post is mainly in the generatedprint_openqa.sh.depends-on: https://gitlab.suse.de/openqa/openqa-trigger-from-ibs-plugin/-/merge_requests/263
issue: https://progress.opensuse.org/issues/190134