Skip to content

CloudAPI: fix /compose/{id}/manifests endpoint behavior on manifest generation errors (HMS-9501) #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 7, 2025
Merged

CloudAPI: fix /compose/{id}/manifests endpoint behavior on manifest generation errors (HMS-9501) #4885

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
062c5db
internal/test: print response body on status check in APICall.Do()
thozza Oct 6, 2025
ca3d489
internal/cloudapi: use complete minimal dummy package for depsolve mock
thozza Oct 6, 2025
95e6f77
internal/cloudapi: ensure manifests are generated in multi-tenancy test
thozza Oct 6, 2025
90af71d
internal/cloudapi: add test for ComposeManifests API endpoint
thozza Oct 6, 2025
7d7702b
internal/cloudapi: include manifest serialize error in JobError details
thozza Oct 6, 2025
ec1e622
internal/cloudapi: check JobError in ComposeManifest endpoint
thozza Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/cloudapi/v2/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ func serializeManifest(ctx context.Context, manifestSource *manifest.Manifest, w
ms, err := manifestSource.Serialize(depsolveResultsInTheRightFormat, containerSpecs, ostreeCommitSpecs, nil)
if err != nil {
reason := "Error serializing manifest"
jobResult.JobError = clienterrors.New(clienterrors.ErrorManifestGeneration, reason, nil)
jobResult.JobError = clienterrors.New(clienterrors.ErrorManifestGeneration, reason, err.Error())
return
}

Expand Down