internal/cloudapi: rename OverrideSerializeManifestFunc for consistency #4887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
requested review from
achilleas-k,
bcl,
croissanne,
lzap,
mvo5 and
supakeen
and removed request for
a team and
lzap
Rename the function to MockSerializeManifestFunc() to be consistent with how we name function like this one. Additionally, name the return func() 'restore' to signal its purpose. Signed-off-by: Tomáš Hozza <[email protected]>
thozza
force-pushed
the
pr-4885-followup
branch
from
4437fce to
911ddd5
Compare
supakeen
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the function to MockSerializeManifestFunc() to be consistent with how we name function like this one. Additionally, name the return func() 'restore' to signal its purpose.