Skip to content

Improved OnLocalhost #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improved OnLocalhost #25

wants to merge 3 commits into from

Conversation

theHenks
Copy link

This PR updates the OnLocalhost runmode to allow julia_flags as well as a dir to be parsed. This allows the number of threads as well as the heap-size-hint per local worker to be set independent of the main process, e.g.

rmode = LocalRun(n = 10, julia_flags =Cmd(["--threads=8", "--heap-size-hint=2G"]))

In addition, OnLocalhost was deprecated and renamed to LocalRun.

@oschulz
Copy link
Owner

oschulz commented Aug 5, 2025

Actually, runworkers(OnLocalhost()) reads nicer than runworkers(LocalRun()). Should we rename SlurmRun to OnSLURM and HTCondorRun to OnHTCondor instead?

@theHenks
Copy link
Author

theHenks commented Aug 5, 2025

Actually, runworkers(OnLocalhost()) reads nicer than runworkers(LocalRun()). Should we rename SlurmRun to OnSLURM and HTCondorRun to OnHTCondor instead?

Fine with me. I would just like to streamline the names. Should I go ahead and change that?

@oschulz
Copy link
Owner

oschulz commented Aug 6, 2025

Should I go ahead and change that?

Yes, let's do it.

@theHenks
Copy link
Author

theHenks commented Aug 6, 2025

Done. Let's run the tests and merge?

@oschulz
Copy link
Owner

oschulz commented Aug 6, 2025

Running ...

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.45%. Comparing base (893f081) to head (afbc8d4).

Files with missing lines Patch % Lines
src/htcondor.jl 0.00% 4 Missing ⚠️
src/slurm.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   67.39%   67.45%   +0.06%     
==========================================
  Files          19       20       +1     
  Lines        1426     1429       +3     
==========================================
+ Hits          961      964       +3     
  Misses        465      465              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theHenks
Copy link
Author

theHenks commented Aug 6, 2025

I do not understand the error on windows. It somehow fails while checking the nprocs() in test_onworkers.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants