Skip to content

Conversation

martincostello
Copy link
Contributor

What kind of change does this PR introduce?

Remove redundant code from when pull_request_target was used that was removed by #2672.

What is the current behavior?

A redundant always-passing job runs (Integration tests / approve (pull_request)).

What is the new behavior (if this is a feature change)?**

The redundant job has been removed.

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

None.

Does this PR introduce a user-facing change?

No.

NONE

Remove redundant code from when `pull_request_target` was used that was removed by ossf#2672.

Signed-off-by: Martin Costello <[email protected]>

Signed-off-by: Martin Costello <[email protected]>
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes redundant code from the integration workflow by eliminating an always-passing approval job that was left over from when pull_request_target was used (removed in #2672).

  • Removes the approve job that served no functional purpose
  • Removes the dependency on the approve job from integration-trusted
  • Cleans up associated comments explaining the approval mechanism

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 2, 2025
@martincostello martincostello changed the title chore: remove redundant code 🌱 remove redundant code Oct 2, 2025
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.89%. Comparing base (353ed60) to head (3bfeac7).
⚠️ Report is 254 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4810      +/-   ##
==========================================
+ Coverage   66.80%   67.89%   +1.09%     
==========================================
  Files         230      249      +19     
  Lines       16602    19124    +2522     
==========================================
+ Hits        11091    12985    +1894     
- Misses       4808     5277     +469     
- Partials      703      862     +159     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spencerschrock spencerschrock enabled auto-merge (squash) October 10, 2025 23:48
@spencerschrock spencerschrock merged commit 0889c73 into ossf:main Oct 10, 2025
37 checks passed
@martincostello martincostello deleted the remove-redundant-comments branch October 11, 2025 06:54
gabrielsoltz pushed a commit to gabrielsoltz/scorecard that referenced this pull request Oct 16, 2025
Remove redundant code from when `pull_request_target` was used that was removed by ossf#2672.

Signed-off-by: Martin Costello <[email protected]>
Signed-off-by: Gabriel Alejandro Soltz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants