-
Notifications
You must be signed in to change notification settings - Fork 576
🌱 remove redundant code #4810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 remove redundant code #4810
Conversation
Remove redundant code from when `pull_request_target` was used that was removed by ossf#2672. Signed-off-by: Martin Costello <[email protected]> Signed-off-by: Martin Costello <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes redundant code from the integration workflow by eliminating an always-passing approval job that was left over from when pull_request_target
was used (removed in #2672).
- Removes the
approve
job that served no functional purpose - Removes the dependency on the
approve
job fromintegration-trusted
- Cleans up associated comments explaining the approval mechanism
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4810 +/- ##
==========================================
+ Coverage 66.80% 67.89% +1.09%
==========================================
Files 230 249 +19
Lines 16602 19124 +2522
==========================================
+ Hits 11091 12985 +1894
- Misses 4808 5277 +469
- Partials 703 862 +159 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Remove redundant code from when `pull_request_target` was used that was removed by ossf#2672. Signed-off-by: Martin Costello <[email protected]> Signed-off-by: Gabriel Alejandro Soltz <[email protected]>
What kind of change does this PR introduce?
Remove redundant code from when
pull_request_target
was used that was removed by #2672.What is the current behavior?
A redundant always-passing job runs (
Integration tests / approve (pull_request)
).What is the new behavior (if this is a feature change)?**
The redundant job has been removed.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
None.
Does this PR introduce a user-facing change?
No.