feat(pci-kubernetes): delete shadcn, debug and install ods 19 #19444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppprevost
force-pushed
the
feat/pci-kubernetes_add-ods_tapc-5001
branch
3 times, most recently
from
c3970d4 to
dfd2ff3
Compare
ppprevost
requested review from
Tsiorifamonjena,
aTurmo,
fredericvilcot,
lionel95200x,
lolottetheclash and
manoncarbonnel
ppprevost
force-pushed
the
feat/pci-kubernetes_add-ods_tapc-5001
branch
from
dfd2ff3 to
e24a8d6
Compare
manoncarbonnel
previously approved these changes
Oct 1, 2025
aTurmo
reviewed
Oct 1, 2025
| onClick, | ||
| }: TPciCardProps) => { | ||
| // TODO : fix badge background color with tailwind | ||
| // TODO : replace #f3fdff by --ods-color-information-025 when the custom property is fixed |
There was a problem hiding this comment.
line 29 : waiting for Tailwind update by CT 👉 normal
line 30 : should be removed by ODS update to v19.1.0 soon
Comment on lines
36
to
38
| className={clsx( | ||
| ' flex flex-col items-center text-center px-[24px] py-[16px] min-h-[200px] rounded-md ', | ||
| )} |
There was a problem hiding this comment.
suggestion : clsx seems useless here
| ODS_TEXT_SIZE, | ||
| } from '@ovhcloud/ods-components'; | ||
| import { OsdsMessage, OsdsSpinner, OsdsText } from '@ovhcloud/ods-components/react'; | ||
| import { OsdsButton, OsdsMessage, OsdsSpinner, OsdsText } from '@ovhcloud/ods-components/react'; |
There was a problem hiding this comment.
suggestion: you should migrate thoses components to ODS19 (since it's the pr purpose)
There was a problem hiding this comment.
the purpose of the PR is to install ODS 19
There was a problem hiding this comment.
Ok
But you added OdsButton, why not add it in ODS19 instead ? Expecially since you already have Badge and Icon in ODS19
ppprevost
force-pushed
the
feat/pci-kubernetes_add-ods_tapc-5001
branch
from
e24a8d6 to
448ecd9
Compare
ppprevost
changed the title
ppprevost
changed the title
lolottetheclash
requested changes
Oct 1, 2025
ppprevost
force-pushed
the
feat/pci-kubernetes_add-ods_tapc-5001
branch
2 times, most recently
from
58bedbc to
8d9c2b4
Compare
aTurmo
previously approved these changes
Oct 1, 2025
ppprevost
force-pushed
the
feat/pci-kubernetes_add-ods_tapc-5001
branch
from
8d9c2b4 to
fb82a74
Compare
ppprevost
force-pushed
the
feat/add-static-analysis-kube
branch
from
9b44ab1 to
06e28b1
Compare
github-actions
bot
added
the
has conflicts
ppprevost
force-pushed
the
feat/pci-kubernetes_add-ods_tapc-5001
branch
from
fb82a74 to
25f6489
Compare
ppprevost
force-pushed
the
feat/add-static-analysis-kube
branch
from
06e28b1 to
30898b7
Compare
ppprevost
force-pushed
the
feat/pci-kubernetes_add-ods_tapc-5001
branch
from
25f6489 to
0c229e6
Compare
ppprevost
requested review from
Masta2000,
T-Mouhmouh,
aTurmo,
b-fritz-ovh,
fredericvilcot,
jperchoc and
manoncarbonnel
and removed request for
a team
ref: #TAPC-5164 Signed-off-by: Pierre-Philippe <[email protected]>
ppprevost
force-pushed
the
feat/pci-kubernetes_add-ods_tapc-5001
branch
2 times, most recently
from
9273b82 to
9f698f8
Compare
github-actions
bot
removed
has conflicts
ppprevost
force-pushed
the
feat/pci-kubernetes_add-ods_tapc-5001
branch
from
9f698f8 to
d6f7e35
Compare
aTurmo
approved these changes
Oct 9, 2025
lolottetheclash
approved these changes
Oct 9, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #TAPC-5001
Description
Ticket Reference: #...
Additional Information