fix(web-domains): remove navigate (-1) #19459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBrendan
reviewed
Oct 1, 2025
There was a problem hiding this comment.
I think you can move this file to common : https://github.com/ovh/manager/blob/feat/web-domain-data/packages/manager/apps/web-domains/src/domain/hooks/generateUrl/useGenerateUrl.ts
And use it to don't duplicate code :)
SBrendan
previously approved these changes
Oct 1, 2025
kb-ovh
previously approved these changes
Oct 2, 2025
louisbensiovh
force-pushed
the
fix/DCE-2
branch
2 times, most recently
from
2003e40 to
04e931e
Compare
kb-ovh
previously approved these changes
Oct 7, 2025
nfoufeovh
previously approved these changes
Oct 8, 2025
ref: #DCE-2 Signed-off-by: Louis BENSI <[email protected]>
louisbensiovh
force-pushed
the
fix/DCE-2
branch
from
04e931e to
410db49
Compare
kb-ovh
approved these changes
Oct 8, 2025
SBrendan
approved these changes
Oct 8, 2025
This was referenced Oct 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove navigate(-1) because if a user come from an external link, he's not redirected into the previous page.
Ticket Reference: #DCE-2