fix(pci-instances): disable vnc tab instead hiding #19466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
translation required
universe-public-cloud
bug
Tsiorifamonjena
force-pushed
the
fix/TAPC-5134
branch
from
c31db06 to
ff036d6
Compare
Tsiorifamonjena
requested review from
manoncarbonnel,
ppprevost,
lionel95200x,
aTurmo,
lolottetheclash and
fredericvilcot
lolottetheclash
previously approved these changes
Oct 1, 2025
packages/manager/apps/pci-instances/src/data/hooks/instance/selectors/instances.selector.ts
Outdated
Show resolved
Hide resolved
ref: #TAPC-5134 Signed-off-by: tsiorifamonjena <[email protected]> Co-authored-by: CDS Translator Agent <[email protected]>
Tsiorifamonjena
force-pushed
the
fix/TAPC-5134
branch
from
ff036d6 to
fcfdeb1
Compare
lolottetheclash
approved these changes
Oct 1, 2025
fredericvilcot
approved these changes
Oct 1, 2025
| return acc.set(type, [rest]); | ||
| }, new Map<TInstanceAddressType, TAggregatedInstanceAddress[]>()); | ||
|
|
||
| const isActionToDisplay = (name: TActionName) => name !== 'vnc'; |
There was a problem hiding this comment.
We must find later another way to achieve this and thus to prevent from having this business rule into the client logic ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket Reference: #TAPC-5134
Additional Information