Skip to content

re-enable flow scanner #6262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

re-enable flow scanner #6262

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d08ffd7
re enable flow scanner
RubenHalman Oct 2, 2025
c93a385
update ref
RubenHalman Oct 2, 2025
8012a3f
bump to 5.8
RubenHalman Oct 2, 2025
c5493b2
update scope and description
RubenHalman Oct 2, 2025
b6e9532
correct version numbering
RubenHalman Oct 2, 2025
1e2d3bf
correct version number
RubenHalman Oct 2, 2025
8f22c5e
update description
RubenHalman Oct 2, 2025
3a4457c
Merge branch 'main' into flow-scanner
RubenHalman Oct 2, 2025
363f0d2
scope changes
RubenHalman Oct 2, 2025
7ac1ff4
update namespace
RubenHalman Oct 4, 2025
48a4f33
version bump
RubenHalman Oct 4, 2025
fdecfe8
revert name to lighnting-flow-scanner
RubenHalman Oct 4, 2025
8fe5b5d
update mkdocs
RubenHalman Oct 5, 2025
4db54c8
update descriptor file
RubenHalman Oct 5, 2025
d6d4995
correct type
RubenHalman Oct 5, 2025
9ed9a75
Merge branch 'main' into flow-scanner
RubenHalman Oct 5, 2025
e42d750
rm cli
RubenHalman Oct 6, 2025
ab2aecf
revert to previous scope
RubenHalman Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .automation/generated/linter-helps.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .automation/generated/linter-licenses.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"kubeconform": "Apache-2.0",
"kubescape": "Apache-2.0",
"kubeval": "Other",
"lightning-flow-scanner": "AGPL-3.0",
"lightning-flow-scanner-cli": "AGPL-3.0",
"lintr": "Other",
"ls-lint": "MIT",
"luacheck": "MIT",
Expand Down
4 changes: 2 additions & 2 deletions .automation/generated/linter-links-previews.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,10 @@
"image": "https://avatars2.githubusercontent.com/u/49038473?s=400&v=4",
"title": "instrumenta/kubeval"
},
"lightning-flow-scanner": {
"lightning-flow-scanner-cli": {
"description": "Lightning-Flow-Scanner has 5 repositories available. Follow their code on GitHub.",
"image": "https://avatars.githubusercontent.com/u/148573214?s=280&v=4",
"title": "Lightning-Flow-Scanner"
"title": "Flow-Scanner"
},
"lintr": {
"description": "Static Code Analysis for R. Contribute to r-lib/lintr development by creating an account on GitHub.",
Expand Down
2 changes: 1 addition & 1 deletion .automation/generated/linter-versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"kubeconform": "0.7.0",
"kubescape": "3.0.41",
"kubeval": "0.16.1",
"lightning-flow-scanner": "3.29.0",
"lightning-flow-scanner-cli": "3.29.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Version Mismatch in Tool Configuration

The linter-versions.json file lists lightning-flow-scanner-cli at version 3.29.0, but the Dockerfile, documentation, and other installation sources reference version 1.4.0. This inconsistency can cause the wrong tool version to be installed or used.

Fix in Cursor Fix in Web

"lintr": "0.0.0",
"ls-lint": "2.3.1",
"luacheck": "1.2.0",
Expand Down
1 change: 1 addition & 0 deletions .automation/generated/linters_matrix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@
"salesforce_sfdx_scanner_apex",
"salesforce_sfdx_scanner_aura",
"salesforce_sfdx_scanner_lwc",
"salesforce_lightning_flow_scanner",
"scala_scalafix",
"snakemake_lint",
"snakemake_snakefmt",
Expand Down
9 changes: 9 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,8 @@ ARG GEM_RUBOCOP_RAKE_VERSION=0.7.1
ARG GEM_RUBOCOP_RSPEC_VERSION=3.7.0
# renovate: datasource=npm depName=@salesforce/sfdx-scanner
ARG SALESFORCE_SFDX_SCANNER_VERSION=4.12.0
# renovate: datasource=npm depName=lightning-flow-scanner
ARG LIGHTNING_FLOW_SCANNER_VERSION=5.8.0
# renovate: datasource=pypi depName=snakemake
ARG PIP_SNAKEMAKE_VERSION=9.11.6
# renovate: datasource=pypi depName=snakefmt
Expand Down Expand Up @@ -1111,6 +1113,13 @@ RUN curl -sSfL https://raw.githubusercontent.com/anchore/syft/refs/tags/v${REPOS
# RUN sf plugins install @salesforce/sfdx-scanner@${SALESFORCE_SFDX_SCANNER_VERSION} \
# && (npm cache clean --force || true) \
# && rm -rf /root/.npm/_cacache
#
# lightning-flow-scanner installation

&& echo y|sf plugins install lightning-flow-scanner-cli@${LIGHTNING_FLOW_SCANNER_VERSION} \
&& (npm cache clean --force || true) \
&& rm -rf /root/.npm/_cacache \

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dockerfile Syntax Error in Installation Commands

The lightning-flow-scanner installation commands are malformed. They begin with && without a preceding RUN instruction, and a trailing backslash on line 1121 is followed by an empty line. This creates invalid Dockerfile syntax and causes the Docker build to fail.

Fix in Cursor Fix in Web

#
# scalafix installation
&& ./coursier install scalafix --quiet --install-dir /usr/bin && rm -rf /root/.cache \
Expand Down
1 change: 1 addition & 0 deletions flavors/salesforce/flavor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"SALESFORCE_SFDX_SCANNER_APEX",
"SALESFORCE_SFDX_SCANNER_AURA",
"SALESFORCE_SFDX_SCANNER_LWC",
"SALESFORCE_LIGHTNING_FLOW_SCANNER",
"SNAKEMAKE_LINT",
"SNAKEMAKE_SNAKEFMT",
"SPELL_CSPELL",
Expand Down
2 changes: 1 addition & 1 deletion linters/salesforce_lightning_flow_scanner/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ RUN sf plugins install @salesforce/plugin-packaging@${NPM_SALESFORCE_PLUGIN_PACK
ENV SF_AUTOUPDATE_DISABLE=true SF_CLI_DISABLE_AUTOUPDATE=true
#
# lightning-flow-scanner installation
RUN echo y|sf plugins install lightning-flow-scanner@${LIGHTNING_FLOW_SCANNER_VERSION} \
RUN echo y|sf plugins install lightning-flow-scanner-cli@${LIGHTNING_FLOW_SCANNER_VERSION} \
&& (npm cache clean --force || true) \
&& rm -rf /root/.npm/_cacache
#
Expand Down
1 change: 1 addition & 0 deletions megalinter/descriptors/all_flavors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,7 @@
"SALESFORCE_SFDX_SCANNER_APEX",
"SALESFORCE_SFDX_SCANNER_AURA",
"SALESFORCE_SFDX_SCANNER_LWC",
"SALESFORCE_LIGHTNING_FLOW_SCANNER",
"SNAKEMAKE_LINT",
"SNAKEMAKE_SNAKEFMT",
"SPELL_CSPELL",
Expand Down
16 changes: 7 additions & 9 deletions megalinter/descriptors/salesforce.megalinter-descriptor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,7 @@ linters:
url: https://marketplace.visualstudio.com/items?itemName=salesforce.salesforcedx-vscode

# Lightning Flow Scanner
- linter_name: lightning-flow-scanner
disabled: true
disabled_reason: Repo archived -> https://github.com/Lightning-Flow-Scanner
- linter_name: lightning-flow-scanner-cli
files_sub_directory: force-app
linter_text: |
**Lightning Flow Scanner** is a specialized SFDX plugin that analyzes Salesforce Flows for integrity issues, performance problems, and adherence to best practices. It helps developers build reliable and maintainable Flow automations.
Expand All @@ -286,7 +284,7 @@ linters:
- **SFDX Native**: Built as a native SFDX plugin for consistent Salesforce toolchain integration

If your root folder is not **force-app**, please set variable SALESFORCE_LIGHTNING_FLOW_SCANNER_DIRECTORY
linter_url: https://github.com/Lightning-Flow-Scanner
linter_url: https://github.com/Flow-Scanner
linter_repo: https://github.com/Lightning-Flow-Scanner/lightning-flow-scanner-sfdx
linter_rules_url: https://github.com/Lightning-Flow-Scanner/lightning-flow-scanner-core#rules
linter_banner_image_url: https://raw.githubusercontent.com/Lightning-Flow-Scanner/.github/main/docs/images/bannerslim.png
Expand All @@ -303,7 +301,7 @@ linters:
cli_version_extra_args:
- "plugins"
cli_version_arg_name: ""
version_extract_regex: "(?<=lightning-flow-scanner )\\d+(\\.\\d+)+"
version_extract_regex: "(?<=lightning-flow-scanner-cli )\\d+(\\.\\d+)+"
cli_lint_errors_count: regex_number
cli_lint_errors_regex: "- error: ([0-9]+)"
test_folder: salesforce-lfs
Expand All @@ -312,13 +310,13 @@ linters:
install:
dockerfile:
- |-
# renovate: datasource=npm depName=lightning-flow-scanner
ARG LIGHTNING_FLOW_SCANNER_VERSION=5.2.0
# renovate: datasource=npm depName=lightning-flow-scanner-cli
ARG LIGHTNING_FLOW_SCANNER_VERSION=5.8.0
- |-
RUN echo y|sf plugins install lightning-flow-scanner@${LIGHTNING_FLOW_SCANNER_VERSION} \
RUN echo y|sf plugins install lightning-flow-scanner-cli@${LIGHTNING_FLOW_SCANNER_VERSION} \
&& (npm cache clean --force || true) \
&& rm -rf /root/.npm/_cacache
ide:
vscode:
- name: Lightning Flow Scanner
url: https://marketplace.visualstudio.com/items?itemName=ForceConfigControl.lightningflowscanner
url: https://marketplace.visualstudio.com/items?itemName=ForceConfigControl.lightning-flow-scanner-vsx
2 changes: 1 addition & 1 deletion megalinter/tests/test_megalinter/linters/salesforce_lightning_flow_scanner_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@

class salesforce_lightning_flow_scanner_test(TestCase, LinterTestRoot):
descriptor_id = "SALESFORCE"
linter_name = "lightning-flow-scanner"
linter_name = "lightning-flow-scanner-cli"
2 changes: 1 addition & 1 deletion mkdocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ nav:
- "sfdx-scanner-apex": "descriptors/salesforce_sfdx_scanner_apex.md"
- "sfdx-scanner-aura": "descriptors/salesforce_sfdx_scanner_aura.md"
- "sfdx-scanner-lwc": "descriptors/salesforce_sfdx_scanner_lwc.md"
- "lightning-flow-scanner": "descriptors/salesforce_lightning_flow_scanner.md"
- "lightning-flow-scanner-cli": "descriptors/salesforce_lightning_flow_scanner-cli.md"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Documentation Link Mismatch

The mkdocs.yml update references descriptors/salesforce_lightning_flow_scanner-cli.md, but the actual documentation file was not renamed to include the -cli suffix. This mismatch creates a broken link in the documentation navigation.

Fix in Cursor Fix in Web

- "SCALA":
- "All SCALA linters": "descriptors/scala.md"
- "scalafix": "descriptors/scala_scalafix.md"
Expand Down
Loading