Skip to content

Commit cb0ae10

Browse files
committed
[Library] Issue #7 : Change way of inputElement and textareaElement default value
1 parent 41675c6 commit cb0ae10

File tree

7 files changed

+11
-14
lines changed

7 files changed

+11
-14
lines changed

src/JsonTree.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ const defaultProps = {
7676
beforeUpdateAction: (key, keyPath, deep, oldValue, newValue) => new Promise(resolve => resolve()),
7777
logger: { error: () => {} },
7878
onSubmitValueParser: (isEditMode, keyPath, deep, name, rawValue) => parse(rawValue),
79-
// inputElement : (usage, keyPath, deep, keyName, data, dataType)
80-
// textareaElement : (usage, keyPath, deep, keyName, data, dataType)
79+
inputElement: (usage, keyPath, deep, keyName, data, dataType) => <input />,
80+
textareaElement: (usage, keyPath, deep, keyName, data, dataType) => <textarea />,
8181
/* eslint-enable */
8282
};
8383

src/components/JsonAddValue.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const propTypes = {
2121
onlyValue: PropTypes.bool,
2222
addButtonElement: PropTypes.element,
2323
cancelButtonElement: PropTypes.element,
24-
inputElementGenerator: PropTypes.func,
24+
inputElementGenerator: PropTypes.func.isRequired,
2525
keyPath: PropTypes.array,
2626
deep: PropTypes.number,
2727
onSubmitValueParser: PropTypes.func.isRequired,
@@ -31,7 +31,6 @@ const defaultProps = {
3131
onlyValue: false,
3232
addButtonElement: <button>+</button>,
3333
cancelButtonElement: <button>c</button>,
34-
inputElementGenerator: () => <input />,
3534
};
3635

3736
/* ************************************* */

src/components/JsonArray.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ const propTypes = {
3232
addButtonElement: PropTypes.element,
3333
cancelButtonElement: PropTypes.element,
3434
editButtonElement: PropTypes.element,
35-
inputElementGenerator: PropTypes.func,
36-
textareaElementGenerator: PropTypes.func,
35+
inputElementGenerator: PropTypes.func.isRequired,
36+
textareaElementGenerator: PropTypes.func.isRequired,
3737
minusMenuElement: PropTypes.element,
3838
plusMenuElement: PropTypes.element,
3939
beforeRemoveAction: PropTypes.func,

src/components/JsonFunctionValue.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const propTypes = {
2929
getStyle: PropTypes.func.isRequired,
3030
editButtonElement: PropTypes.element,
3131
cancelButtonElement: PropTypes.element,
32-
textareaElementGenerator: PropTypes.func,
32+
textareaElementGenerator: PropTypes.func.isRequired,
3333
minusMenuElement: PropTypes.element,
3434
logger: PropTypes.object.isRequired,
3535
onSubmitValueParser: PropTypes.func.isRequired,
@@ -42,7 +42,6 @@ const defaultProps = {
4242
},
4343
editButtonElement: <button>e</button>,
4444
cancelButtonElement: <button>c</button>,
45-
textareaElementGenerator: () => <textarea />,
4645
minusMenuElement: <span> - </span>,
4746
};
4847

src/components/JsonNode.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ const propTypes = {
3434
addButtonElement: PropTypes.element,
3535
cancelButtonElement: PropTypes.element,
3636
editButtonElement: PropTypes.element,
37-
inputElementGenerator: PropTypes.func,
38-
textareaElementGenerator: PropTypes.func,
37+
inputElementGenerator: PropTypes.func.isRequired,
38+
textareaElementGenerator: PropTypes.func.isRequired,
3939
minusMenuElement: PropTypes.element,
4040
plusMenuElement: PropTypes.element,
4141
beforeRemoveAction: PropTypes.func,

src/components/JsonObject.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ const propTypes = {
3232
addButtonElement: PropTypes.element,
3333
cancelButtonElement: PropTypes.element,
3434
editButtonElement: PropTypes.element,
35-
inputElementGenerator: PropTypes.func,
36-
textareaElementGenerator: PropTypes.func,
35+
inputElementGenerator: PropTypes.func.isRequired,
36+
textareaElementGenerator: PropTypes.func.isRequired,
3737
minusMenuElement: PropTypes.element,
3838
plusMenuElement: PropTypes.element,
3939
beforeRemoveAction: PropTypes.func,

src/components/JsonValue.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const propTypes = {
2929
getStyle: PropTypes.func.isRequired,
3030
editButtonElement: PropTypes.element,
3131
cancelButtonElement: PropTypes.element,
32-
inputElementGenerator: PropTypes.func,
32+
inputElementGenerator: PropTypes.func.isRequired,
3333
minusMenuElement: PropTypes.element,
3434
logger: PropTypes.object.isRequired,
3535
onSubmitValueParser: PropTypes.func.isRequired,
@@ -41,7 +41,6 @@ const defaultProps = {
4141
handleUpdateValue: () => Promise.resolve(),
4242
editButtonElement: <button>e</button>,
4343
cancelButtonElement: <button>c</button>,
44-
inputElementGenerator: () => <input />,
4544
minusMenuElement: <span> - </span>,
4645
};
4746

0 commit comments

Comments
 (0)