-
Notifications
You must be signed in to change notification settings - Fork 3
Add Mac build script for CI and development #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cafca
wants to merge
40
commits into
main
Choose a base branch
from
pv/mac
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know the MR it's still a draft. Reflection will stick to GNOME's commit message style. Shouldn't be too much work since the commit history still needs cleanup anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
scripts/build_macos.sh
, which builds Reflection for macOS using Meson. Adds a CI step to build for mac and upload the resulting app bundle to Github for new commits onmain
.Adds a
workflow_dispatch
trigger to the CI task so that it can be triggered manually on any branch from Github's web UI.Uses the system keyring on macOS for storing user credentials. This means that a popup asks the user if they want to allow Reflection access to its keyring when the app starts.
Updates resource loading to work in macOS app bundles where the app may be moved around to any location in the system and paths need to be relative to the bundle for that to work.
Caveats
sudo xattr -rd com.apple.quarantine /Applications/Aardvark.app
unless I was using a build made on the same machineTodo
Still needs some cleanup, documentation, and rebasing to remove unrelated changes.