PHP 8.4 support

.github/workflows/ci.yaml

@@ -10,26 +10,19 @@ jobs:
         runs-on: ubuntu-latest
         strategy:
             matrix:
-                php: [7.1, 7.2, 7.3, 7.4, 8.0, 8.1, 8.2]
+                php: [7.1, 7.2, 7.3, 7.4, 8.0, 8.1, 8.2, 8.3, 8.4]
         steps:
-            - uses: actions/checkout@v2
+            - uses: actions/checkout@v4
+
             - name: Install PHP ${{ matrix.php }}
               uses: "shivammathur/setup-php@v2"
               with:
                   coverage: "none"
                   ini-values: "memory_limit=-1, phar.readonly=0"
                   php-version: ${{ matrix.php }}
 
-            - name: "Determine composer cache directory"
-              id: "determine-composer-cache-directory"
-              run: "echo \"::set-output name=directory::$(composer config cache-dir)\""
-
-            - name: "Cache dependencies installed with composer"
-              uses: "actions/cache@v1"
-              with:
-                  path: "${{ steps.determine-composer-cache-directory.outputs.directory }}"
-                  key: "php-${{ matrix.php }}-ci"
-                  restore-keys: "php-${{ matrix.php }}"
+            - name: Install dependencies
+              uses: ramsey/composer-install@v3
 
             - name: "Install dependencies"
               run: composer update --no-progress -o --prefer-dist

lib/Bitbucket/API/Api.php

@@ -49,7 +49,7 @@ class Api
      * @param OptionalClientOption $options
      * @param ClientInterface $client
      */
-    public function __construct(array $options = array(), ClientInterface $client = null)
+    public function __construct(array $options = array(), ?ClientInterface $client = null)
     {
         $this->httpClient = (null !== $client) ? $client : new Client($options, null);
 

lib/Bitbucket/API/Http/Client.php

@@ -51,7 +51,7 @@ class Client implements ClientInterface
     /**
      * @param OptionalClientOption $options
      */
-    public function __construct(array $options = array(), HttpPluginClientBuilder $httpClientBuilder = null)
+    public function __construct(array $options = array(), ?HttpPluginClientBuilder $httpClientBuilder = null)
     {
         $this->responseHistory = new HistoryPlugin();
         $this->options = array_merge(array_merge($this->options, $options));

lib/Bitbucket/API/Http/HttpPluginClientBuilder.php

@@ -30,7 +30,7 @@ class HttpPluginClientBuilder
     /**
      * @param MessageFactory|RequestFactoryInterface|null $requestFactory
      */
-    public function __construct(ClientInterface $httpClient = null, $requestFactory = null, StreamFactoryInterface $streamFactory = null)
+    public function __construct(?ClientInterface $httpClient = null, $requestFactory = null, ?StreamFactoryInterface $streamFactory = null)
     {
         $requestFactory = $requestFactory ?? Psr17FactoryDiscovery::findRequestFactory();
         if ($requestFactory instanceof MessageFactory) {

lib/Bitbucket/API/Http/Plugin/ApiVersionPlugin.php

@@ -27,7 +27,7 @@ public function __construct($version)
      * @param callable $next Next middleware in the chain, the request is passed as the first argument
      * @param callable $first First middleware in the chain, used to to restart a request
      *
-     * @return Promise<ResponseInterface> Resolves a PSR-7 Response or fails with an Http\Client\Exception (The same as HttpAsyncClient).
+     * @return Promise Resolves a PSR-7 Response or fails with an Http\Client\Exception (The same as HttpAsyncClient).
      */
     protected function doHandleRequest(RequestInterface $request, callable $next, callable $first)
     {

lib/Bitbucket/API/Http/Response/Pager.php

@@ -38,7 +38,7 @@ public function __construct(
         HttpPluginClientBuilder $httpPluginClientBuilder,
         ResponseInterface $response,
         $messageFactory = null,
-        StreamFactoryInterface $streamFactory = null
+        ?StreamFactoryInterface $streamFactory = null
     ) {
         /** @var ResponseInterface $response */
         if ($response->getStatusCode() >= 400) {