Refactor and enhance Azure Opex Dashboard functionality #290

gunzip · 2025-09-12T09:48:19Z

Introduce a structured approach to the Azure Opex Dashboard with improved configuration validation, streamlined CLI commands, and enhanced testing. I

Update documentation and contributing guidelines to reflect the new structure and features.

…tion, and OA3 resolver

… for testing

…ate tests to verify behavior

…ation utilities and implementing Zod schemas for improved type safety and validation

…to utils, and update references in resolver and endpoint-parser

…line the project structure

…edundant comments and streamline resource group naming

… consolidate dashboard generation to use AzureDashboardCdkBuilder

…amline command handling and improve error reporting

…ipt package

…orts to use module syntax and improve error handling

…emove unused cdktf.json, and enhance error handling in OA3Resolver

… stack

…ated imports

…ons; enhance tsup configuration for better output

…dency for opex-dashboard-ts and upgrade cdktf provider version

…ted imports; remove unused azure-opex-cdk.ts file

- Created metadata.json for the Opex Dashboard stack, defining various availability and response time alerts. - Implemented addAzureDashboard function to initialize the AzureOpexStack with validated configuration and parsed endpoints. - Integrated OpenAPI spec resolution and endpoint parsing for dynamic dashboard generation.

…te tests

- Separate domain, application, and infrastructure layers - Implement ports & adapters pattern - Move business logic to domain services - Create adapters for external dependencies - Update tests and documentation - All tests passing

…alidation

…orAdapter; refactor related services and update exports

…ations

changeset-bot · 2025-09-12T09:48:23Z

⚠️ No Changeset found

Latest commit: 34061c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/opex-dashboard-ts/src/domain/services/kusto-query-service.ts

+      path
+        .replace(/\{[^}]+\}/g, "[^/]+") // Replace {param} with [^/]+


packages/opex-dashboard-ts/src/domain/services/path-utils.ts

+
+/* Convert placeholders like {serviceId} or {ServiceID} to {service_id} for display */
+export function normalizePathPlaceholders(path: string): string {
+  return path.replace(/\{([^}]+)\}/g, (_, name) => `{${toSnakeCase(name)}}`);


packages/opex-dashboard-ts/src/infrastructure/terraform/azure-alerts.ts

+      input
+        .trim()
+        // remove leading slashes to avoid leading underscores later
+        .replace(/^\/+/, "")
+        // normalize spaces and unsupported chars
+        .replace(/\s+/g, "-")
+        .replace(/[{}]/g, "")
+        .replace(/[^a-zA-Z0-9-_/]/g, "-")
+        // drop trailing slashes first
+        .replace(/\/+$/g, "")


… infrastructure

.github/workflows/infra_plan_opex.yaml

+
+      - name: Get terraform version from .terraform-version file
+        id: get-version
+        uses: pagopa/dx/.github/actions/get-terraform-version@main


.github/workflows/infra_plan_opex.yaml

+          done
+
+      - name: Azure Login
+        uses: pagopa/dx/.github/actions/azure-login@main


.github/workflows/infra_plan_opex.yaml

+
+      - name: Terraform Setup
+        id: set-terraform-version
+        uses: pagopa/dx/.github/actions/terraform-setup@main


.github/workflows/infra_plan_opex.yaml

+      - name: Post Plan on PR
+        id: comment
+        if: always() && github.event_name == 'pull_request'
+        uses: pagopa/dx/actions/pr-comment@main


… for generated infrastructure

…Review workflow

…pendencies in turbo.json

github-actions · 2025-09-14T10:37:34Z

This PR exceeds the recommended size of 800 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2025-09-14T10:38:18Z

Tip

✅ All Terraform module locks are up to date

No module changes detected - everything is in sync!

📋 Pre-commit Output Log

[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/pagopa/dx.
Lock Terraform Registry modules..........................................Passed

_{Generated on Sun Sep 14 10:38:17 UTC 2025
Run lock_modules on folder: infra/resources/dev/}

github-actions · 2025-09-14T10:40:18Z

📋 Pre-commit Output Log

[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/pagopa/dx.
Lock Terraform Registry modules......................(no files to check)Skipped

_{Generated on Sun Sep 14 10:40:17 UTC 2025
Run lock_modules on folder: test-opex-api/stacks/opex-dashboard/}

gunzip added 30 commits September 10, 2025 12:43

Add code style guidelines to copilot instructions

c34616f

OPEX dashboard refactor skeleton

4a68ce9

Implement Azure Dashboard and Alerts Builders with CLI support

7265adf

Add unit tests for CLI commands, endpoint parsing, Kusto query genera…

815601c

…tion, and OA3 resolver

Add Vitest configuration for testing in opex-dashboard-ts package

88e5d23

Remove build script and update TypeScript configuration to use Vitest…

d00c4e2

… for testing

Add Zod validation for configuration and update CLI command to use it

ce88436

Enhance configuration validation with detailed error messages and upd…

b8daa9b

…ate tests to verify behavior

Refactor configuration handling by replacing openapi types with valid…

7932e14

…ation utilities and implementing Zod schemas for improved type safety and validation

Refactor OpenAPI type handling by moving OpenAPISpec and type guards …

c4c6e78

…to utils, and update references in resolver and endpoint-parser

Remove comprehensive test, demo CLI, and validation scripts to stream…

ec20851

…line the project structure

Refactor AzureAlertsConstruct and AzureDashboardConstruct to remove r…

6408724

…edundant comments and streamline resource group naming

Refactor CLI command to remove template-name option and update tests;…

46817c6

… consolidate dashboard generation to use AzureDashboardCdkBuilder

Refactor dashboard generation to use generateDashboard function; stre…

6c416ba

…amline command handling and improve error reporting

chore: add tsup configuration for building the Opex Dashboard TypeScr…

ad5fce6

…ipt package

Format files

bac876a

chore: update package.json and add ESLint configuration; refactor imp…

726075f

…orts to use module syntax and improve error handling

refactor: update README and CLI commands; replace ts-node with tsx, r…

c51a964

…emove unused cdktf.json, and enhance error handling in OA3Resolver

refactor: consolidate Azure dashboard and alerts creation in the same…

6cf7dc2

… stack

refactor: rename AzureDashboardStack to AzureOpexStack and update rel…

5989eb4

…ated imports

refactor: update package.json exports and improve TypeScript definiti…

e98460d

…ons; enhance tsup configuration for better output

refactor: update VSCode settings for TypeScript formatting; add depen…

c90060b

…dency for opex-dashboard-ts and upgrade cdktf provider version

refactor: rename AzureOpexConstruct to AzureOpexStack and update rela…

22d6d99

…ted imports; remove unused azure-opex-cdk.ts file

refactor: update .gitignore and clean up package.json dependencies

2433137

fix: replace hardcoded resource group name with config value and upda…

977ed08

…te tests

feat: refactor to hexagonal architecture

180d490

- Separate domain, application, and infrastructure layers - Implement ports & adapters pattern - Move business logic to domain services - Create adapters for external dependencies - Update tests and documentation - All tests passing

feat: implement OA3Resolver and Endpoint parsing utilities with Zod v…

8d1a40c

…alidation

fix: update CLI entry path in tsup configuration

b982d9d

feat: implement CreateDashboardStackUseCase and TerraformStackGenerat…

304a56f

…orAdapter; refactor related services and update exports

feat: add Infra OPEX Code Review workflow and update related configur…

dc1b3fc

…ations

github-actions bot assigned gunzip Sep 12, 2025

github-actions bot added workflows infra size/large labels Sep 12, 2025

gunzip had a problem deploying to infra-dev-ci September 12, 2025 09:49 — with GitHub Actions Failure

github-advanced-security bot found potential problems Sep 12, 2025

View reviewed changes

feat: add Terraform plan workflow for Infra OPEX and commit generated…

8a95151

… infrastructure

github-advanced-security bot found potential problems Sep 12, 2025

View reviewed changes

gunzip had a problem deploying to infra-dev-ci September 12, 2025 13:04 — with GitHub Actions Failure

feat: update Infra OPEX workflows to use artifact upload and download…

15540ef

… for generated infrastructure

gunzip had a problem deploying to infra-dev-ci September 12, 2025 13:08 — with GitHub Actions Failure

feat: enable Corepack in Infra OPEX Code Review workflow

ee31ace

gunzip had a problem deploying to infra-dev-ci September 12, 2025 13:12 — with GitHub Actions Failure

feat: add build step for dependencies in Infra OPEX Code Review workflow

236e164

gunzip had a problem deploying to infra-dev-ci September 12, 2025 13:15 — with GitHub Actions Failure

feat: add build step for generating dependencies in Infra OPEX workflow

5782be8

gunzip had a problem deploying to infra-dev-ci September 12, 2025 13:18 — with GitHub Actions Failure

fix: remove incorrect build step for dependencies in Infra OPEX Code …

c29d847

…Review workflow

gunzip had a problem deploying to infra-dev-ci September 12, 2025 13:27 — with GitHub Actions Failure

fix: update standalone:copy script to use -p flag for mkdir

6f81d6f

gunzip had a problem deploying to infra-dev-ci September 13, 2025 13:42 — with GitHub Actions Failure

fix: remove unnecessary generate step from build script and adjust de…

aa6a084

…pendencies in turbo.json

gunzip had a problem deploying to infra-dev-ci September 13, 2025 14:10 — with GitHub Actions Failure

fix: remove duplicate checkout step in infra_plan_opex workflow

34061c5

gunzip had a problem deploying to infra-dev-ci September 14, 2025 10:38 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor and enhance Azure Opex Dashboard functionality #290

Refactor and enhance Azure Opex Dashboard functionality #290

Uh oh!

gunzip commented Sep 12, 2025

Uh oh!

changeset-bot bot commented Sep 12, 2025 •

edited

Loading

Uh oh!

Check failure

Check failure

Check failure

Check warning

Check warning

Check warning

Check warning

github-actions bot commented Sep 14, 2025

Uh oh!

github-actions bot commented Sep 14, 2025

✅ All Terraform module locks are up to date

Uh oh!

github-actions bot commented Sep 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		path
		.replace(/\{[^}]+\}/g, "[^/]+") // Replace {param} with [^/]+

Refactor and enhance Azure Opex Dashboard functionality #290

Are you sure you want to change the base?

Refactor and enhance Azure Opex Dashboard functionality #290

Uh oh!

Conversation

gunzip commented Sep 12, 2025

Uh oh!

changeset-bot bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Check failure

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

github-actions bot commented Sep 14, 2025

Uh oh!

github-actions bot commented Sep 14, 2025

✅ All Terraform module locks are up to date

Uh oh!

github-actions bot commented Sep 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot bot commented Sep 12, 2025 •

edited

Loading