Skip to content

Conversation

@michele-fucito
Copy link
Collaborator

@michele-fucito michele-fucito commented Oct 14, 2025

Description

List of changes

Migrated dependency management from requirements.txt files to pyproject.toml with extras for functional-tests, bdd-tests, ux-tests, performance-tests, contract-tests, dev, and end-to-end-tests.
Updated Makefile with new targets: install-dev, install-functional, install-bdd, install-ux, install-performance, install-contract, install-end-to-end, test-end-to-end, and check-env.
Moved flaky end-to-end tests (using TEST_TIMEOUT_SEC) from functional-tests/tests/ to new end-to-end-test/tests/ folder.
Added pytest markers and testpaths to pyproject.toml for consistent configuration.
Updated .github/workflows/run_tests.yml: added EndToEnd input, EndToEnd_Tests job (after Contract_Tests), updated Aggregate_Results to include end-to-end results, added permissions: contents: read, adjusted cron to '0 6 * * *' (08:00 CEST).
Removed legacy files (requirements.txt, setup.py, pytest.ini)
Updated gpd-test/docker/Dockerfile to install from pyproject.toml instead of requirements.txt.

Motivation and context

Migrated to pyproject.toml for modern Python packaging and better dependency isolation. Separated flaky end-to-end tests to avoid impacting CI stability. Updated CI workflow to include end-to-end suite with proper aggregation and permissions for security. Adjusted schedule to run at 08:00 local time. Archived legacy files after verification.

Aggregation level

  • Test case
  • Test suite

Test type

  • Functional test
  • Smoke test
  • End to end
  • Performance

Type of changes

  • Add new test case/suite
  • Modify existing test case/suite

Test Results

  • Success
  • Failure
  • Poor performance
  • Good performance

Did you update secrets accordingly?

  • Yes
    • .secrets_template.yaml
    • Pipelines' secure file
    • Confluence
  • Not needed
  • No (please provide further information)

Did you update dependencies accordingly?

  • Yes (which requirements.txt did you update?)
  • Not needed

Other information

@michele-fucito michele-fucito marked this pull request as ready for review October 14, 2025 15:14
@lucaconsalvi lucaconsalvi requested a review from Copilot October 15, 2025 07:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request modernizes the test suite infrastructure by migrating from requirements.txt files to pyproject.toml with optional dependencies, introducing end-to-end tests as a separate category, and updating the CI/CD workflow for improved dependency management and test organization.

  • Migrated dependency management from individual requirements.txt files to centralized pyproject.toml with extras for different test types
  • Separated flaky end-to-end tests from functional tests into dedicated end-to-end-test directory
  • Updated CI workflow to include end-to-end test execution with proper scheduling and permissions

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Added complete project configuration with optional dependencies for all test types and pytest markers
Makefile Created comprehensive build targets for installing dependencies and running tests
.github/workflows/run_tests.yml Updated CI workflow to use pyproject.toml, added end-to-end tests job, and adjusted scheduling
install-requirements.sh Added installation script that leverages Makefile targets
README.md Updated documentation to reflect new dependency management and installation process
functional-tests/requirements.txt Removed legacy requirements file
functional-tests/pytest.ini Removed legacy pytest configuration
bdd-tests/requirements.txt Removed legacy requirements file
ux-tests/pytest.ini Removed legacy pytest configuration
setup.py Removed legacy setup file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@michele-fucito michele-fucito merged commit 690dc9c into main Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants