Skip to content

Conversation

cainmagi
Copy link

@cainmagi cainmagi commented Mar 26, 2024

Fix the typehint inconsistence of db.relationship(...).

Rebased on the branch 3.1.x.

This work is continued from #1319

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
    • Only bug fixing. No need to do this.
  • Add or update relevant docs, in the docs folder and in code.
    • Only bug fixing. No need to do this.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
    • Only bug fixing. No need to add any change logs for users.
  • Add .. versionchanged:: entries in any relevant code docs.
    • Only bug fixing. No need to do this.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

Make the typehint of `SQLAlchemy.relationship` consistent with `sqlalchemy.orm.relationship`.
This issue may be caused by upgrade of `tox>=4`. My tox version is 4.12.0.

See details here: https://stackoverflow.com/a/47716994/8266012
@jdimmerman
Copy link
Contributor

Hey @davidism! Any thoughts on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants