Skip to content

add missing | None to copy argument in concat #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Aug 13, 2025

Precursor to extending #1318 to keyword-only arguments

🤔 though arguably, copy is deprecated on the pandas main branch, so perhaps shouldn't be done?

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

@MarcoGorelli
Copy link
Member Author

Actually, as per #1293 (comment)

I looked further into the copy argument issue. Eventually, that argument will be removed. So I think it would be best to not change copy: _bool = False or copy: _bool = True to be copy: _bool | None = None, because None won't be accepted in the future. So ignore those requests in my review.

this probably shouldn't be changed at all

Closing this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant