Skip to content

Updates prohibited parameters. - #14

Open
rwagner00 wants to merge 2 commits into
1.xfrom
prohibited-parameter
Open

rwagner00 wants to merge 2 commits into
1.xfrom
prohibited-parameter

Conversation

@rwagner00

Copy link
Copy Markdown
Contributor

No description provided.

@rwagner00
rwagner00 requested a review from a team May 25, 2022 15:17
Comment thread README.md Outdated
* `terminus composer my-site.dev -- update`

### Note
* The `--no-scripts` parameter is not supported on the Pantheon platform. If your workflow requires this parameter, run the command locally and push the resulting `composer.json` and `composer.lock` files to your repository.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --no-scripts parameter is not supported by some Pantheon upstreams.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a list of which ones?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any workflows require this parameter.

Also, if you run the command locally, you'll need export COMPOSER_ROOT_VERSION=dev-main in order to use --no-scripts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a list of which ones?

Right now, only pantheon-upstreams/drupal-composer-managed, and any custom upstream based on it. Likely, the WordPress Bedrock / Composer-managed upstream will work the same way.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that in mind I think just leaving it on "Some" is probably for the best, just so nobody is surprised if they try it and experience issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants