Styling Fix #168
Merged
Styling Fix #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the left side navigation styling by adding an active state style for Table of Contents (TOC) items and fixing unwanted spacing issues caused by empty nested navigation structures.
Key changes:
- Adds visual styling for active TOC links with background color and border radius
- Implements logic to conditionally render navigation containers only when they contain visible children
- Refactors the template to pre-filter visible children instead of filtering during iteration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| material-overrides/partials/nav-item.html | Added logic to check for visible children before rendering navigation containers, preventing empty divs that cause spacing issues |
| material-overrides/assets/stylesheets/polkadot.css | Added active state styling for TOC links with background color and border radius across different screen sizes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@0xlukem please tag me here or DM me in slack when this is ready for me. Thanks! |
eshaben
reviewed
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new active style for the TOC and fixes some spacing issues on the left side navigation.
Before:
After:
The issue was caused because mkdocs resolved that the section block explorer was a nested one (like the one above) and added a div, which caused the extra blank space. So, I added logic to check if there is real nested content or not.