feat: atomic ntoken

[0x8f701]

Signed-off-by: GopherJ [email protected]

Security Checklist

• 1. Re-Entrancy
• 2. Arithmetic Over/Under Flows
• 3. Unexpected Ether
• 4. Delegatecall
• 5. Default Visibilities
• 6. Entropy Illusion
• 7. External Contract Referencing
• 8. Short Address/Parameter Attack (off chain)
• 9. Unchecked CALL Return Values
• 10. Race Conditions / Front Running
• 11. Denial Of Service (DOS)
• 12. Block Timestamp Manipulation
• 13. Constructors with Care
• 14. Uninitialized Storage Pointers
• 15. Floating Points and Precision
• 16. Tx.Origin Authentication
• 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

[codecov]

Codecov Report

Merging #326 (e9c2b17) into main (fcb705c) will increase coverage by 0.55%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   75.24%   75.80%   +0.55%     
==========================================
  Files          83       83              
  Lines        3826     3918      +92     
  Branches      714      737      +23     
==========================================
+ Hits         2879     2970      +91     
+ Misses        571      560      -11     
- Partials      376      388      +12     

Impacted Files	Coverage Δ
...ntracts/protocol/tokenization/NTokenApeStaking.sol	74.19% <ø> (ø)
...ontracts/protocol/tokenization/NTokenUniswapV3.sol	7.40% <20.00%> (+3.24%)	⬆️
contracts/ui/UiPoolDataProvider.sol	59.64% <33.33%> (-0.24%)	⬇️
...acts/protocol/libraries/logic/LiquidationLogic.sol	97.03% <66.66%> (+0.02%)	⬆️
...ontracts/protocol/tokenization/NTokenMoonBirds.sol	68.42% <66.66%> (ø)
contracts/protocol/tokenization/NToken.sol	36.92% <83.33%> (-0.96%)	⬇️
...l/tokenization/base/MintableIncentivizedERC721.sol	65.68% <83.33%> (+9.84%)	⬆️
...col/tokenization/libraries/MintableERC721Logic.sol	83.41% <92.10%> (+4.99%)	⬆️
contracts/protocol/libraries/helpers/Helpers.sol	100.00% <100.00%> (ø)
...ontracts/protocol/libraries/logic/GenericLogic.sol	70.29% <100.00%> (+3.94%)	⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[0x8f701]

we should optimize the gas cost here because we are not using all these anymore in GenericLogic

[0x8f701]

this should still take the same slot 67