-
Notifications
You must be signed in to change notification settings - Fork 85
Add mcp-notify server manifest #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added configuration for mcp-notify server with details on messaging capabilities and required arguments.
WalkthroughAdds a new MCP Notify server manifest describing metadata, credential configuration arguments, multiple notification tools with input schemas (WeWork, Telegram, Ding, Lark), and an installation entry for launching the server. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client as Caller
participant Manifest as MCP Notify (manifest)
participant Server as MCP Notify (runtime)
participant WeWork as WeWork API
participant Telegram as Telegram API
participant Ding as Ding API
participant Lark as Lark API
Note over Client,Manifest: Caller selects a tool and supplies payload
Client->>Manifest: select tool + payload
Manifest->>Server: route request with configured args (tokens, chats)
alt Telegram tool
Server->>Telegram: POST sendMessage / sendPhoto (uses TELEGRAM_BOT_TOKEN)
Telegram-->>Server: response
end
alt WeWork tool
Server->>WeWork: POST send_text or send_image (uses WEWORK_BOT_KEY)
WeWork-->>Server: response
end
alt Ding or Lark tool
Server->>Ding: POST send_text (uses DINGTALK_BOT_KEY)
Server->>Lark: POST send_text (uses LARK_BOT_KEY)
Ding-->>Server: response
Lark-->>Server: response
end
Server-->>Client: success / error
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Files needing attention:
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
mcp-registry/servers/mcp-notify.json (1)
100-103: Consider type alignment for message ID fields.The
reply_to_message_idfields in bothtg_send_messageandtg_send_photoare typed as"string", but Telegram's API typically expects integers. Verify whether string type is intentional for flexibility or a type mismatch. If IDs must be integers, consider updating the schema.Also applies to: 128-131
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
mcp-registry/servers/mcp-notify.json(1 hunks)
🔇 Additional comments (1)
mcp-registry/servers/mcp-notify.json (1)
1-151: JSON structure and schema are well-formed.The manifest follows the expected registry structure with complete metadata, clear tool definitions, proper input schemas with required fields, and installation instructions. All tools have appropriate descriptions and examples.
Updated the description to reflect the supported platforms and added new message sending functionalities for DingTalk and Lark/Feishu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
mcp-registry/servers/mcp-notify.json(1 hunks)
🔇 Additional comments (2)
mcp-registry/servers/mcp-notify.json (2)
41-193: Tool definitions are well-structured.All six tools have consistent schemas with clear descriptions, appropriate required fields, and descriptive property documentation. The parameter names and types align with their respective platform conventions (e.g.,
msgtypefor WeWork/DingTalk,parse_modefor Telegram). JSON syntax is valid.
195-206: Installation and metadata are correct.The uvx installation configuration and manifest metadata (name, display_name, repository, author, license, categories) are well-defined and consistent with the MCP server registry conventions.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
User description
Added manifest for mcp-notify server with details on messaging capabilities and required arguments.
https://github.com/aahl/mcp-notify
PR Type
Enhancement
Description
Add mcp-notify server manifest to registry
Define messaging capabilities for multiple platforms
Configure WeWork, Telegram integration tools
Specify installation and authentication requirements
Diagram Walkthrough
File Walkthrough
mcp-notify.json
Complete mcp-notify server manifest configurationmcp-registry/servers/mcp-notify.json
message/photo
defaults
and tags
Summary by CodeRabbit