-
Notifications
You must be signed in to change notification settings - Fork 370
feat(theme): add high contrast theme poc #11911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview: https://patternfly-react-pr-11911.surge.sh A11y report: https://patternfly-react-pr-11911-a11y.surge.sh |
Hi @mcoker & @melissaing For the HC POC demo — would it be possible to make the following updates so the POC fits with the research tasks?
If these updates sound doable to you, could you also give me an estimate to communicate back to research on how long the following updates would take? Thank you sm! |
@lboehling - I'm going to pitch in. I should be able to knock the button/drawer change out in like 20 minutes unless you have specific things you want in the notifications. Just let me know - this estimate is based on pulling in this sample code here: https://www.patternfly.org/components/notification-drawer#basic. I'll get you an estimate for form validation once I'm done with this. |
Only bell icon should toggle drawer.
Form looks similar time-wise to me (I haven't been in Form in a few years). I won't make the email matching more robust than your use case needs if that works. |
Added validation for name and email only, even though other fields are marked as required. Assisted-by: Cursor (used to generate regexes)
I did some extra stuff - wired up cancel to clear it and added validation for name, but not the other fields. There is no message on a successful submit but I wired it up to clear. Let me know if you want something different here. |
Just popping out name validation since it's not needed + clearing out controlled checkbox + description on submit for funsies. |
This PR was replaced with #11954
The new demo URL is https://patternfly-react-pr-11954.surge.sh/patterns/high-contrast/react-demos/high-contrast/
High contrast POC. You can find it under "Patterns" -> "High Contrast", or click this handy-dandy link
https://patternfly-react-pr-11911.surge.sh/patterns/high-contrast/react-demos/high-contrast/
To enable theme, turn on high contrast on your OS or you can use forced-colors mode in dev tools (below)
Core styles are in this branch - https://github.com/mcoker/patternfly/tree/hc-theme-poc-styles. To hook up to this POC, I make the changes in core, then compile and copy/paste them into the react docs dir as additional stylesheets using the command below.