fix(Select): improve type consistency in onSelect
#11935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11935.surge.sh A11y report: https://patternfly-react-pr-11935-a11y.surge.sh Preview: https://pf-react-pr-11935.surge.sh A11y report: https://pf-react-pr-11935-a11y.surge.sh |
nicolethoen
approved these changes
Jul 25, 2025
Since this is loosening a type, nothing should break as users of the callback can continue to use only strings or numbers as before |
kmcfaul
requested changes
Jul 30, 2025
| @@ -56,7 +57,7 @@ export interface SelectProps extends MenuProps, OUIAProps { | |||
| /** @beta Flag indicating the first menu item should be focused after opening the menu. */ | |||
| shouldFocusFirstItemOnOpen?: boolean; | |||
| /** Function callback when user selects an option. */ | |||
| onSelect?: (event?: React.MouseEvent<Element, MouseEvent>, value?: string | number) => void; | |||
| onSelect?: (event?: React.MouseEvent<Element, MouseEvent>, value?: SelectOptionProps['value']) => void; | |||
There was a problem hiding this comment.
Menu's onSelect should also be updated to reference MenuItem's itemId.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11361
Non-breaking change to loosen the expected type of
onSelect'svalueparameter, to matchSelectOptionPropsAdditional issues:
This PR wold allow for the removal of a bunch of
ts-expect-errors I added in openshift/console#14783