Skip to content

feat(853): favorite button codemod #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025

Conversation

gitdallas
Copy link
Contributor

closes #853

@gitdallas gitdallas self-assigned this Aug 11, 2025
@gitdallas gitdallas force-pushed the feat/favorite-button-codemod branch from 82f52b3 to 088e9cf Compare August 11, 2025 21:13
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gitdallas ! Tested this locally and this is looking great - left some comments below.

@gitdallas gitdallas force-pushed the feat/favorite-button-codemod branch from 088e9cf to 4ac3e9f Compare August 12, 2025 22:27
@gitdallas gitdallas requested a review from jenny-s51 August 12, 2025 22:29
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gitdallas , LGTM

@gitdallas gitdallas force-pushed the feat/favorite-button-codemod branch from 4ac3e9f to 3f12591 Compare August 15, 2025 14:23
@gitdallas gitdallas merged commit fed60da into patternfly:main Aug 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button - support isFavorite and isFavorited on Button for animation styling
4 participants