Skip to content

chore: Emotion conversion #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: Emotion conversion #585

wants to merge 1 commit into from

Conversation

epwinchell
Copy link
Collaborator

@epwinchell epwinchell commented Jan 29, 2025 •
edited
Loading

Jira: https://issues.redhat.com/browse/RHCLOUD-36480

  • Includes initial install of Emotion

@epwinchell epwinchell marked this pull request as draft January 29, 2025 22:22
@patternfly-build
Copy link

patternfly-build commented Jan 29, 2025 •
edited
Loading

Preview: https://react-component-groups-pr-component-groups-585.surge.sh

A11y report: https://react-component-groups-pr-component-groups-585-a11y.surge.sh

@epwinchell epwinchell force-pushed the emotion_3 branch 4 times, most recently from e6de4c8 to 1856bff Compare January 29, 2025 22:47
@epwinchell epwinchell changed the title Emotion conversion: Take #2 Chore: Emotion conversion: Take #2 Jan 29, 2025
@epwinchell epwinchell marked this pull request as ready for review January 29, 2025 23:00
@epwinchell epwinchell requested a review from fhlavac January 29, 2025 23:00
@epwinchell epwinchell force-pushed the emotion_3 branch 6 times, most recently from 3774f22 to 3fe28cf Compare January 30, 2025 18:56
@epwinchell epwinchell changed the title Chore: Emotion conversion: Take #2 chore: Emotion conversion: Take #2 Jan 30, 2025
@epwinchell epwinchell force-pushed the emotion_3 branch 2 times, most recently from 276e7c0 to 65ac010 Compare January 30, 2025 19:19
@epwinchell epwinchell changed the title chore: Emotion conversion: Take #2 chore: Emotion conversion Jan 30, 2025
@epwinchell epwinchell force-pushed the emotion_3 branch 3 times, most recently from 381f99b to d2b640d Compare January 31, 2025 18:02
@epwinchell epwinchell requested review from Hyperkid123 and removed request for fhlavac February 3, 2025 14:57
@dlabaj
Copy link
Collaborator

dlabaj commented Apr 23, 2025 •
edited
Loading

@epwinchell
Since we are moving to astro for the documentation framework @Hyperkid123 and I discussed having this as part of that initiative. Is it okay to close this issue for now and revisit it once the framework is available?

dlabaj
dlabaj requested changes Aug 15, 2025
View reviewed changes
Copy link
Collaborator

@dlabaj dlabaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should close this pull request and look at removing in line styles. We also have astro work coming that will address some of this. I'm going to close since it's been sitting here for awhile. If we need to reopen it we can.

@dlabaj dlabaj closed this Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlabaj dlabaj dlabaj requested changes

@Hyperkid123 Hyperkid123 Awaiting requested review from Hyperkid123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epwinchell @patternfly-build @dlabaj