Avoid from Html injection #372
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a function that encoding the html tags to avoid html injection.
adarshmadrecha
approved these changes
Apr 11, 2019
pawelczak
requested changes
Oct 2, 2019
| config.get("list").onMouseOutEvent(); | ||
| }) | ||
| .html(template.build(highlight(elementsValue, phrase), listData[j])); | ||
| .html(template.build(highlight(htmlEntities(elementsValue), phrase), listData[j])); |
There was a problem hiding this comment.
It would be nice to add a config flag for this HTML injection feature, so a user can decide whether they want to use it or not. It can be enabled by default.
There was a problem hiding this comment.
Yeah you are right. I forget the flags. I will check it tonight.
| $field.after($elements_container); | ||
| } | ||
|
|
||
| function htmlEntities(str) { |
There was a problem hiding this comment.
Can you rename this method to striHTMLTags?
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a function that encoding the html tags to avoid html injection.