refactor: update ModalFragment to use newInstance factory #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clientId handling - Replaced direct constructor calls to ModalFragment with newInstance method across tests and implementation files. - Added tests to ensure proper state restoration and argument handling for ModalFragment. - Updated ModalFragment class to include a companion object for argument management, ensuring compatibility with Android's fragment lifecycle.
Contributor
Code Coverage
|
- Introduced unit tests for ModalFragment, validating configuration creation and event handling. - Added tests for Channel enum and OkHttpCompat utility class, ensuring proper functionality and error handling. - Updated jacoco.gradle to require XML and CSV report formats for coverage reports.
…lifecycle management - Updated ModalFragment to use default values for close button properties during recreation, ensuring consistent behavior. - Improved close button functionality to properly dismiss the fragment, preventing it from being restored unintentionally. - Enhanced PayPalMessageDataProvider to safely dismiss modals during cleanup, avoiding crashes during activity destruction. - Added checks to reuse existing modals only if they are still added to the fragment manager, improving resource management.
- Added tests to verify that dismissed ModalFragments are not restored after activity recreation. - Implemented checks to ensure new instances of ModalFragments are created when showing modals after dismissal. - Enhanced onCreateView test to handle null close button data gracefully, preventing crashes during fragment recreation. - Verified that onDismiss callback is invoked correctly when a fragment is dismissed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Testing instructions
Go to the developer options on the device. Set Don't Keep Activities to on
Open the xml demo. Click the message then the android home button. Reopen the demo app. Its should not crash.
Modal should be in state you left it in.