PSMDB-1078: simulate replica set for inmemory_kv_engine_test... #1591
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... otherwise all tests which rely on timestamps will fail because the table logging will be enabled - see WiredTigerUtil::useTableLogging.
There was a problem hiding this comment.
Pull Request Overview
This PR configures the in-memory storage engine test harness to simulate replica set mode, enabling timestamping tests to run correctly. This change aligns the in-memory test setup with the WiredTiger test harness implementation.
- Sets global replication settings to simulate replica set mode
- Updates ReplicationCoordinatorMock initialization to use the configured settings
- Modernizes the code by using std::make_unique instead of raw pointer construction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plebioda
deleted the
PSMDB-1078-fix-inmemory_kv_engine_test-master-v6.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... otherwise all tests which rely on timestamps will fail because the table logging will be enabled - see WiredTigerUtil::useTableLogging.