Skip to content

Conversation

eminaktas
Copy link
Contributor

@eminaktas eminaktas commented Jul 23, 2025

This commit introduces the extraPVCs field in CRD, allowing users to attach additional PVC to main container. #2126

CHANGE DESCRIPTION

Problem:
Short explanation of the problem.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2025

CLA assistant check
All committers have signed the CLA.

@eminaktas eminaktas force-pushed the feat/add-extra-pvcs branch from 05eea44 to 4b200ca Compare July 24, 2025 08:03
@hors hors added the community label Jul 24, 2025
@eminaktas eminaktas force-pushed the feat/add-extra-pvcs branch 2 times, most recently from f311f14 to 0784a09 Compare July 28, 2025 08:09
@egegunes egegunes added this to the v1.19.0 milestone Jul 28, 2025
@eminaktas eminaktas force-pushed the feat/add-extra-pvcs branch 3 times, most recently from 5079c45 to b833676 Compare August 4, 2025 07:57
Copy link

@SiddharthiMishra SiddharthiMishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voting

@eminaktas eminaktas force-pushed the feat/add-extra-pvcs branch 2 times, most recently from 2e9ee8b to b4cdf92 Compare August 14, 2025 09:53
@egegunes
Copy link
Contributor

hey @eminaktas, since you're still pushing changes, I wonder if this is ready for review?

@eminaktas
Copy link
Contributor Author

hey @eminaktas, since you're still pushing changes, I wonder if this is ready for review?

Hey @egegunes, yes, it’s ready for review now. While running a few tests, I noticed some issues caused by this change. The recent pushes include improvements and fixes I made while digging into the code for other related work.

@gkech
Copy link
Contributor

gkech commented Aug 20, 2025

we have some thoughts about this implementation, but first let us run a small test to verify this approach.

@egegunes
Copy link
Contributor

we also need to confirm the new field name (extraPVCs) with Peter to see if it's okay.

@eminaktas
Copy link
Contributor Author

Since you’re the expert on this, I went with what made the most sense to me at the time. I’d really appreciate hearing your thoughts, since you’re the maintainer and have deeper context.

I haven’t looked into it too deeply yet, but one idea we could also explore is supporting volume expansion for the extra volume.

This commit introduces the `extraPVCs` field in CRD,
allowing users to attach additional PVC to main container. percona#2126

Signed-off-by: Emin Aktas <[email protected]>
@eminaktas eminaktas force-pushed the feat/add-extra-pvcs branch from b4cdf92 to 7baf735 Compare August 26, 2025 08:32
@egegunes
Copy link
Contributor

@gkech could you please play with this to see if it works and feasible?

@egegunes egegunes assigned egegunes and gkech and unassigned egegunes Sep 22, 2025
@JNKPercona
Copy link
Collaborator

Test Name Result Time
affinity-8-0 failure 00:00:00
auto-tuning-8-0 failure 00:00:00
cross-site-8-0 failure 00:00:00
custom-users-8-0 failure 00:00:00
demand-backup-cloud-8-0 failure 00:00:00
demand-backup-encrypted-with-tls-8-0 failure 00:00:00
demand-backup-8-0 failure 00:00:00
demand-backup-flow-control-8-0 failure 00:00:00
demand-backup-parallel-8-0 failure 00:00:00
demand-backup-without-passwords-8-0 skipped 00:00:00
haproxy-5-7 skipped 00:00:00
haproxy-8-0 skipped 00:00:00
init-deploy-5-7 skipped 00:00:00
init-deploy-8-0 skipped 00:00:00
limits-8-0 skipped 00:00:00
monitoring-2-0-8-0 skipped 00:00:00
monitoring-pmm3-8-0 skipped 00:00:00
one-pod-5-7 skipped 00:00:00
one-pod-8-0 skipped 00:00:00
pitr-8-0 skipped 00:00:00
pitr-gap-errors-8-0 skipped 00:00:00
proxy-protocol-8-0 skipped 00:00:00
proxysql-sidecar-res-limits-8-0 skipped 00:00:00
pvc-resize-5-7 skipped 00:00:00
pvc-resize-8-0 skipped 00:00:00
recreate-8-0 skipped 00:00:00
restore-to-encrypted-cluster-8-0 skipped 00:00:00
scaling-proxysql-8-0 skipped 00:00:00
scaling-8-0 skipped 00:00:00
scheduled-backup-5-7 skipped 00:00:00
scheduled-backup-8-0 skipped 00:00:00
security-context-8-0 skipped 00:00:00
smart-update1-8-0 skipped 00:00:00
smart-update2-8-0 skipped 00:00:00
storage-8-0 skipped 00:00:00
tls-issue-cert-manager-ref-8-0 skipped 00:00:00
tls-issue-cert-manager-8-0 skipped 00:00:00
tls-issue-self-8-0 skipped 00:00:00
upgrade-consistency-8-0 skipped 00:00:00
upgrade-haproxy-5-7 skipped 00:00:00
upgrade-haproxy-8-0 skipped 00:00:00
upgrade-proxysql-5-7 skipped 00:00:00
upgrade-proxysql-8-0 skipped 00:00:00
users-5-7 skipped 00:00:00
users-8-0 skipped 00:00:00
validation-hook-8-0 skipped 00:00:00
We run 9 out of 46 N/A

commit: 2b1a171
image: perconalab/percona-xtradb-cluster-operator:PR-2128-2b1a1710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants