-
Notifications
You must be signed in to change notification settings - Fork 199
feat: add support for extraPVCs #2128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
05eea44
to
4b200ca
Compare
f311f14
to
0784a09
Compare
5079c45
to
b833676
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Voting
2e9ee8b
to
b4cdf92
Compare
hey @eminaktas, since you're still pushing changes, I wonder if this is ready for review? |
Hey @egegunes, yes, it’s ready for review now. While running a few tests, I noticed some issues caused by this change. The recent pushes include improvements and fixes I made while digging into the code for other related work. |
we have some thoughts about this implementation, but first let us run a small test to verify this approach. |
we also need to confirm the new field name (extraPVCs) with Peter to see if it's okay. |
Since you’re the expert on this, I went with what made the most sense to me at the time. I’d really appreciate hearing your thoughts, since you’re the maintainer and have deeper context. I haven’t looked into it too deeply yet, but one idea we could also explore is supporting volume expansion for the extra volume. |
This commit introduces the `extraPVCs` field in CRD, allowing users to attach additional PVC to main container. percona#2126 Signed-off-by: Emin Aktas <[email protected]>
b4cdf92
to
7baf735
Compare
@gkech could you please play with this to see if it works and feasible? |
commit: 2b1a171 |
This commit introduces the
extraPVCs
field in CRD, allowing users to attach additional PVC to main container. #2126CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability