-
Notifications
You must be signed in to change notification settings - Fork 177
PMM-14118 Generate SSL certificates for ClickHouse #4575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #4575 +/- ##
=======================================
Coverage 44.54% 44.54%
=======================================
Files 363 363
Lines 45715 45715
=======================================
Hits 20365 20365
Misses 23692 23692
Partials 1658 1658
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7588ddd
to
5030ef4
Compare
-keyout /srv/nginx/certificate.key \ | ||
-out /srv/nginx/certificate.crt \ | ||
-config /etc/nginx/ssl/certificate.conf | ||
-config /srv/nginx/certificate.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BupycHuk Are we OK with this fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, no issues )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder, wasn't it meant to be that way? I thought it was an oversight, no? If we don't take the certificate.conf
from /srv/nginx/
, then there is no way for the user to override ours, which comes from /etc/nginx/
.
PMM-14118
Link to the Feature Build: SUBMODULES-4054
This pull request introduces SSL support for the ClickHouse server and fixes a configuration path for Nginx certificate generation. The main changes include generating SSL certificates for ClickHouse, adding Diffie-Hellman parameters, and ensuring the correct configuration file is used for Nginx certificate creation.
SSL support for ClickHouse:
server.key
andserver.crt
) for ClickHouse using OpenSSL, improving security for ClickHouse connections.dhparam.pem
file containing Diffie-Hellman parameters for enhanced SSL security, and updated the Ansible copy task to deploy this file to the ClickHouse server directory.Nginx certificate generation fix:
/srv/nginx/certificate.conf
instead of/etc/nginx/ssl/certificate.conf
.