fix: generate new nickname if NicknameEditor loses focus with blank value #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
like it, thank you! |
callebtc
requested changes
Aug 5, 2025
…android into fix-send-message-without-username
yet300
added a commit
to yet300/bitchat-android
that referenced
this pull request
Aug 30, 2025
This commit completely redesigns the "About" bottom sheet. The new design features: * A cleaner, more structured layout with distinct sections for features, appearance, and network settings. * Improved typography and styling that aligns with the rest of the app's UI. * A sticky top bar with a "Done" button that appears on scroll. * The use of string resources for all text content, improving localization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131
Description
This PR updates the
NicknameEditorbehavior to automatically generate a new nickname when the inputBasicTextFieldloses focus and the current value is blank. This ensures that users are always assigned a nickname if they leave the field black.Why this matters
Platform-Specific Behavior
This issue was particularly noticeable on Android devices, where losing focus from the NicknameEditor did not trigger nickname generation when the input was left black.
On iPhones, this behavior already works as expected.
Screen recordings
Screen_recording_20250731_071319.mp4
Checklist