Skip to content

Show shortcuts in Electron native menu items.GH-1923 #8973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RohitBhati8269
Copy link
Contributor

No description provided.

@@ -34,10 +49,12 @@ export default class MainMenuFactory {
MainMenuFactory.electronCallbacks[smName] = sm.callback;
return {
...sm.serialize(),
accelerator: MainMenuFactory.convertShortcutToAccelerator(sm.shortcut),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accelerator will actually register a shortcut. It is not just for labelling. Did you test triggering the shortcut?
Although, it will trigger double shortcut.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the electron side by console when hit the shortcut, it’s not being called twice.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you checked but it is opening 3 query tools for query tool shortcut.

Screen.Recording.2025-07-21.at.09.55.21.mov

@adityatoshniwal
Copy link
Contributor

Closing in favor of bec4784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants