Show shortcuts in Electron native menu items.GH-1923 #8973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityatoshniwal
requested changes
Jul 19, 2025
| @@ -34,10 +49,12 @@ export default class MainMenuFactory { | |||
| MainMenuFactory.electronCallbacks[smName] = sm.callback; | |||
| return { | |||
| ...sm.serialize(), | |||
| accelerator: MainMenuFactory.convertShortcutToAccelerator(sm.shortcut), | |||
There was a problem hiding this comment.
accelerator will actually register a shortcut. It is not just for labelling. Did you test triggering the shortcut?
Although, it will trigger double shortcut.
There was a problem hiding this comment.
I checked the electron side by console when hit the shortcut, it’s not being called twice.
There was a problem hiding this comment.
I don't know what you checked but it is opening 3 query tools for query tool shortcut.
Screen.Recording.2025-07-21.at.09.55.21.mov
|
Closing in favor of bec4784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.