Skip to content

Conversation

mzabuawala
Copy link
Contributor

This PR modifies the SQL query used to retrieve the index metadata to accurately process reloptions for defaults of PostgreSQL index types. Some options, such as fillfactor, deduplicate_items and others, would return NULL when not set, irrespective of internal defaults within PostgreSQL. This would cause misleading or incomplete information regarding the index.

Applied index-type specific defaults when reloptions are not explicitly set:

  • B-tree: fillfactor = 100, deduplicate_items = true
  • GiST: fillfactor = 90, buffering = 'auto'
  • GIN: fastupdate = true, gin_pending_list_limit = 4MB
  • BRIN: pages_per_range = 128, autosummarize = false

Copy link
Contributor

@akshay-joshi akshay-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Murtuza,

I did a quick review, and according to the PostgreSQL documentation, deduplicate_items was introduced in version 13 and above. Therefore, any changes involving this feature in the default folder or "properties.sql" for versions below 13 will result in an error.

Since pgAdmin's default folder maps to PostgreSQL version 10, please address this issue accordingly.

Once you've made the necessary fixes, I'll proceed with testing your PR.

@akshay-joshi akshay-joshi self-requested a review July 21, 2025 08:17
Copy link
Contributor

@akshay-joshi akshay-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Murtuza,

I did a quick review, and according to the PostgreSQL documentation, deduplicate_items was introduced in version 13 and above. Therefore, any changes involving this feature in the default folder or Properties.sql for versions below 13 will result in an error.

Since pgAdmin's default folder maps to PostgreSQL version 10, please address this issue accordingly.

Once you've made the necessary fixes, I'll proceed with testing your PR.

@akshay-joshi akshay-joshi dismissed their stale review July 21, 2025 08:18

Review need to block merge

@mzabuawala mzabuawala requested a review from akshay-joshi July 21, 2025 18:53
@akshay-joshi akshay-joshi merged commit e73d8f4 into pgadmin-org:master Jul 28, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants