Commiting Changes to handle partition maintenance on Partition table … #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which is being referred by another table.
|
This looks good but would like to get a unit test in place to ensure it works as expected now and in the future. If you have a chance to do one in the near future, then I can immediately merge this in as a bug fix and get a patch release out. Otherwise I'll look at getting that unit test done and in with 5.4 when that release is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier in 4.7.1 we had column in part_config table drop_cascade_Fk, so if the partitioned table on which maintenance was run using run_maintenance, if it had any Reference then those things use to get dropped. But that was not right, I guess that reason it has been removed from 5.1.0 version. But a new problem comes if partitioned table is being referred then run maintenance will fail. In order to handle this we need to detach partition before dropping it, hence I have made the changes in two place where partition was being dropped, this should work smoothly without any issue even when partition table is being referred by another table.
had reported this as issue in #767