Skip to content

Fix typo in conditional jump methods #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: pharo-12
Choose a base branch
from
Open

Fix typo in conditional jump methods #1016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
559c178
Fix typo in conditional jump methods
m-demare Aug 26, 2025
43430d9
Merge branch 'pharo-12' into typo-jump-if
PalumboN Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 34 additions & 34 deletions smalltalksrc/VMMaker/StackInterpreter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5394,7 +5394,7 @@ StackInterpreter >> extJumpIfFalse [
byte := self fetchByte.
offset := byte + (extB << 8).
numExtB := extB := extA := 0.
self jumplfFalseBy: offset
self jumpIfFalseBy: offset
]

{ #category : 'jump bytecodes' }
Expand All @@ -5404,7 +5404,7 @@ StackInterpreter >> extJumpIfTrue [
byte := self fetchByte.
offset := byte + (extB << 8).
numExtB := extB := extA := 0.
self jumplfTrueBy: offset
self jumpIfTrueBy: offset
]

{ #category : 'miscellaneous bytecodes' }
Expand Down Expand Up @@ -8399,6 +8399,34 @@ StackInterpreter >> jumpBinaryInlinePrimitive: primIndex [
self pop: 2
]

{ #category : 'jump bytecodes' }
StackInterpreter >> jumpIfFalseBy: offset [

| boolean |
boolean := self stackTop.
boolean = objectMemory falseObject
ifTrue: [ self jump: offset ]
ifFalse: [
boolean = objectMemory trueObject ifFalse: [
^ self internalMustBeBoolean ].
self fetchNextBytecode ].
self pop: 1
]

{ #category : 'jump bytecodes' }
StackInterpreter >> jumpIfTrueBy: offset [

| boolean |
boolean := self stackTop.
boolean = objectMemory trueObject
ifTrue: [ self jump: offset ]
ifFalse: [
boolean = objectMemory falseObject ifFalse: [
^ self internalMustBeBoolean ].
self fetchNextBytecode ].
self pop: 1
]

{ #category : 'sista bytecodes' }
StackInterpreter >> jumpTrinaryInlinePrimitive: primIndex [

Expand Down Expand Up @@ -8470,34 +8498,6 @@ StackInterpreter >> jumpUnaryInlinePrimitive: primIndex [
^ self unknownInlinePrimitive
]

{ #category : 'jump bytecodes' }
StackInterpreter >> jumplfFalseBy: offset [

| boolean |
boolean := self stackTop.
boolean = objectMemory falseObject
ifTrue: [ self jump: offset ]
ifFalse: [
boolean = objectMemory trueObject ifFalse: [
^ self internalMustBeBoolean ].
self fetchNextBytecode ].
self pop: 1
]

{ #category : 'jump bytecodes' }
StackInterpreter >> jumplfTrueBy: offset [

| boolean |
boolean := self stackTop.
boolean = objectMemory trueObject
ifTrue: [ self jump: offset ]
ifFalse: [
boolean = objectMemory falseObject ifFalse: [
^ self internalMustBeBoolean ].
self fetchNextBytecode ].
self pop: 1
]

{ #category : 'debug printing' }
StackInterpreter >> lengthOfNameOfClass: classOop [
<inline: false>
Expand Down Expand Up @@ -8612,13 +8612,13 @@ StackInterpreter >> long: aJumpBuf jmp: returnValue [
{ #category : 'jump bytecodes' }
StackInterpreter >> longJumpIfFalse [

self jumplfFalseBy: ((currentBytecode bitAnd: 3) * 256) + self fetchByte.
self jumpIfFalseBy: ((currentBytecode bitAnd: 3) * 256) + self fetchByte.
]

{ #category : 'jump bytecodes' }
StackInterpreter >> longJumpIfTrue [

self jumplfTrueBy: ((currentBytecode bitAnd: 3) * 256) + self fetchByte.
self jumpIfTrueBy: ((currentBytecode bitAnd: 3) * 256) + self fetchByte.
]

{ #category : 'debug printing' }
Expand Down Expand Up @@ -13876,13 +13876,13 @@ StackInterpreter >> setupFrameForNewMethodInterpreted [
{ #category : 'jump bytecodes' }
StackInterpreter >> shortConditionalJumpFalse [

self jumplfFalseBy: (currentBytecode bitAnd: 7) + 1
self jumpIfFalseBy: (currentBytecode bitAnd: 7) + 1
]

{ #category : 'jump bytecodes' }
StackInterpreter >> shortConditionalJumpTrue [

self jumplfTrueBy: (currentBytecode bitAnd: 7) + 1
self jumpIfTrueBy: (currentBytecode bitAnd: 7) + 1
]

{ #category : 'simulation' }
Expand Down