More tests, workflows PR comment for feature test - #405
Open
varunghat wants to merge 14 commits into
Open
Conversation
…s and add-features
varunghat
marked this pull request as draft
August 20, 2026 23:27
Contributor
Author
|
Split into two workflows now (Since PR from forked repo does not have write permissions) First workflow runs the Feature test (test-phonemes.R) first and stores data. Then runs the tests suite. Verified the workflow on my forked branch, PR comment works with PR from a forked repo. Will work once the new workflow file gets added to master. Current test fails are the 5 ISOcodes that do not match with glottolog (More info in this PR that fixes them: #403) |
varunghat
marked this pull request as ready for review
August 21, 2026 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following regression tests:
Added the following new test
Added the following extra test to test-inventory-metadata.R
Excluded test-phonemes.R from github workflows test suite, but added it as a separate job which writes the output as a comment in the PR
Added tasks to pixi.toml (exactly the same as #398)