Skip to content

Make :purge and :delete commands compatible with Symfony 3.0 #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2017
Merged

Make :purge and :delete commands compatible with Symfony 3.0 #346

merged 2 commits into from
Apr 12, 2017

Conversation

PapyDanone
Copy link
Contributor

Replaces Dialog helper calls with ConfirmationQuestion. Without it, they fail if you are not using the --no-confirmation flag. See deprecation notice in symfony docs.

@PapyDanone
Copy link
Contributor Author

The only problem is that the ConfirmationQuestion class was introduced in symfony/console ~2.7. Should we therefore bump the version in composer?

@skafandri skafandri added this to the 2.x.x milestone May 31, 2016
@keksa keksa mentioned this pull request Apr 12, 2017
Closed
@skafandri skafandri merged commit bce6455 into php-amqplib:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.x.x
Development

Successfully merging this pull request may close these issues.
2 participants
@PapyDanone @skafandri