Add ping response timeout handling #210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the MQTT client's connection reliability by introducing logic to detect and handle situations where the broker does not respond to ping requests within the configured keep alive interval. The changes ensure the client can automatically reconnect or throw an exception if the connection is deemed dead, improving fault tolerance and connection management.
Connection reliability improvements:
Added a new property
pingResponseExpectedUntilto track the deadline for receiving a ping response from the broker.In the main loop (
loopOnce), implemented logic to check if a ping response was received in time. If not, the client logs a warning, closes the socket, resets ping tracking, and either reconnects automatically or throws aDataTransferExceptiondepending on settings.Updated the
ping()method to setpingResponseExpectedUntilwhenever a ping request is sent, establishing a deadline for the broker's response. The expected deadline depends on the keep alive interval as specified in the MQTT documentation:Modified
handleMessage()to clearpingResponseExpectedUntilwhen a ping response (PINGRESP) is received, confirming the broker's responsiveness.Socket and connection state management:
disconnect()andcloseSocket()methods set$this->sockettonulland$this->connectedtofalsefor consistent connection state tracking. [1] [2]Fixes #209