add details about optimizer passes #4858
Open
+164
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-lb
reviewed
Sep 3, 2025
realFlowControl
commented
Sep 4, 2025
There was a problem hiding this comment.
There are really just a few external links in the docs, would you think it would be beneficial to link to Nikitas blog post?
As there are only a few external links, I am not sure how this is handled usually
arnaud-lb
approved these changes
Sep 4, 2025
| <row> | ||
| <entry>10</entry> | ||
| <entry>PASS_11</entry> | ||
| <entry>Literal optimization</entry> |
| <row> | ||
| <entry>11</entry> | ||
| <entry>PASS_12</entry> | ||
| <entry>Call stack adjustment</entry> |
There was a problem hiding this comment.
Suggest: Pre-compute call stack size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some digging into optimizer passes in php/php-src#19658 and figured I could just document things a bit more user friendly