-
Notifications
You must be signed in to change notification settings - Fork 829
PHP 8.5 migration guide #4906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
PHP 8.5 migration guide #4906
Conversation
|
I forgot to add UPGRADING for |
|
php/php-src#20239 might also need to be incorporated |
Added in 4f86bb5
Changed in 3d7f6f5 |
|
Added in a288458. |
5369184 to
928e2f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for starting this! I left a lot of comments that I would like to have addressed. :)
| <simpara> | ||
| The <link linkend="object.wakeup">__wakeup()</link> magic method of | ||
| <interfacename>DateTimeInterface</interfacename>, | ||
| <classname>DateTime</classname>, <classname>DateTimeImmutable</classname>, | ||
| <classname>DateTimeZone</classname>, <classname>DateInterval</classname>, | ||
| and <classname>DatePeriod</classname> has been deprecated in favour of | ||
| the <link linkend="object.unserialize">__unserialize()</link> magic method. | ||
| <!-- RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_sleep_and_wakeup_magic_methods --> | ||
| </simpara> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember if this wasn't reverted with the soft deprecation RFC, so this would need to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. deleted in eaa8c68.
| The <constant>MHASH_<replaceable>*</replaceable></constant> constants | ||
| have been deprecated. These have been overlooked when the mhash*() function | ||
| family has been deprecated per | ||
| <!-- RFC: https://wiki.php.net/rfc/deprecations_php_8_1#mhash_function_family --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text doesn't make much sense as the RFC which is being linked to is in a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. deleted mhash*() related description in dc23d16.
| The <link linkend="language.oop5.cloning">clone language construct</link> | ||
| is now a function and supports reassigning (readonly) properties during | ||
| cloning via the new <property>$withProperties</property> parameter. | ||
| <!-- RFC: https://wiki.php.net/rfc/clone_with_v2 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimWolla it cannot be disabled via disable_functions right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for starting this! I left a lot of comments that I would like to have addressed. :)
Co-authored-by: Gina Peter Banyard <[email protected]>
|
Thanks for all the feedback! I've addressed the points you raised, but I'm not sure how to fix the following. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More review comments, not sure I correctly identified the review comment you had issues with as the GitHub UI doesn't work...
| <simpara> | ||
| <function>pg_connect</function> checks if the connection_string argument | ||
| contains any null byte. | ||
| </simpara> | ||
|
|
||
| <simpara> | ||
| <function>pg_close_stmt</function> checks if the statement_name argument | ||
| contains any null byte. | ||
| </simpara> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right so this should be move to the incompatible.xml file as this is a BC change and many of the other value errors are situated there
| <simpara> | ||
| Upgraded pcre2lib from 10.44 to 10.46. | ||
| </simpara> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was downgraded again due to a bug in PCRE, @ndossche please confirm.
Co-authored-by: Gina Peter Banyard <[email protected]>
|
@Girgias ok, nits markup issues addressed again. Also, [ValueError|TypeError] BC break changes are moved in 35ce39c. refs: https://github.com/php/doc-en/pull/4906/files#r2473529673 |
Based on PHP 8.5 UPGRADE NOTES and past migration guides.