Skip to content

Conversation

@kamil-tekiela
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR rewrites the PHP documentation page for callbacks and callables to provide a more comprehensive and up-to-date explanation. The rewrite restructures the content with improved organization, adds detailed examples, and includes information about modern PHP features like first-class callable syntax.

  • Complete restructuring of content with clearer explanations and better organization
  • Addition of comprehensive examples demonstrating different ways to create and use callables
  • Updated information about PHP 8.1+ features and deprecation warnings for PHP 8.2+

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kamil-tekiela
Copy link
Member Author

This is what the page looks like now:
webphp_manual_en_language types callable php

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Definitely an improvement. Some remarks.

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let someone else take another look, but LGTM from my side.

kamil-tekiela and others added 6 commits October 31, 2025 12:55
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Copy link
Contributor

@afilina afilina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the comments and LGTM. I don't see anything as blocking.

@afilina afilina merged commit 147b80d into php:master Oct 31, 2025
2 checks passed
@kamil-tekiela kamil-tekiela deleted the callables branch October 31, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants