- 
                Notifications
    You must be signed in to change notification settings 
- Fork 828
Rewrite the callback and callable page #4933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR rewrites the PHP documentation page for callbacks and callables to provide a more comprehensive and up-to-date explanation. The rewrite restructures the content with improved organization, adds detailed examples, and includes information about modern PHP features like first-class callable syntax.
- Complete restructuring of content with clearer explanations and better organization
- Addition of comprehensive examples demonstrating different ways to create and use callables
- Updated information about PHP 8.1+ features and deprecation warnings for PHP 8.2+
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Definitely an improvement. Some remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let someone else take another look, but LGTM from my side.
Co-authored-by: Tim Düsterhus <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the comments and LGTM. I don't see anything as blocking.

No description provided.