Skip to content

翻訳漏れ修正 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024
Merged

翻訳漏れ修正 #122

merged 1 commit into from
Jul 26, 2024

Conversation

schrosis
Copy link
Contributor

No description provided.

@youkidearitai
Copy link
Contributor

@mumumu CIが別のところで失敗していますが、これは大丈夫そうでしょうかね?

Loading and parsing manual.xml... failed.

ERROR (file:////home/runner/work/doc-ja/doc-ja/ja/reference/xlswriter/book.xml:19:33)
 &reference.xlswriter.constants;
---------------------------------^
 Entity 'reference.xlswriter.constants' not defined


Previous errors too severe. Stopping here.


Eyh man. No worries. Happ shittens. Try again after fixing the errors above.

@youkidearitai
Copy link
Contributor

@schrosis プルリクエストありがとうございます!多分問題ないと思いますが、念の為調べてみますね

@jimwins
Copy link
Member

jimwins commented Jul 26, 2024

PR #121 fixes the build problem.

@youkidearitai
Copy link
Contributor

@jimwins Thank you for follows! I continue this PR as is.

Copy link
Contributor

@youkidearitai youkidearitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
確認しました!

@youkidearitai youkidearitai merged commit 5853965 into php:master Jul 26, 2024
1 check failed
@schrosis schrosis deleted the patch-1 branch July 26, 2024 02:50
@youkidearitai
Copy link
Contributor

ありがとうございました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants