fix php startup errors when ini files contain environment variables#2252
Merged
fix php startup errors when ini files contain environment variables#2252
Conversation
Contributor
|
You can probably also move env initialization before sapi_startup or at the top of Line 1095 in a85faae Then they will be available during startup |
Contributor
Author
moved before frankenphp sapi startup |
AlliBalliBaba
approved these changes
Mar 8, 2026
dunglas
approved these changes
Mar 8, 2026
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr> Signed-off-by: Marc <m@pyc.ac>
Contributor
|
Could we get an version tagged with this fix? |
Contributor
Author
|
It's 4am in Europe currently, so you may have to wait a few hours. |
This was referenced Mar 9, 2026
Merged
dunglas
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2250, closes #2252