Closed
Conversation
Member
|
Not judging the code correctness (CI failure is very legit) but the relevance of it. Not sure what to think but things to consider perhaps like Should we always store this info (ie hiding it behind a ini setting, disabled by default) ? If you do not get feedback in a timely manner, I suggest trying to defend your case in the internal mailing list. Cheers. |
Member
|
Are you aware that this already exists? https://www.php.net/manual/en/mysqli.error.php Besides, what exactly is the point in that? If you can catch the exception then you already have all this info in the exception. |
Member
|
When creating a PR do not add the .patch file. You should also provide sufficient unit testing for the new feature. |
added 4 commits
March 24, 2026 11:31
7ffffbf to
ae0f7b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new property last_query_error in the mysqli class.
The property stores the SQL query that caused the most recent error, providing developers with easier debugging and error tracking.
How to test: