Skip to content

ext/intl: c++ memory management application to timezone class internals. #19184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/intl: c++ memory management application to timezone class internals. #19184

wants to merge 1 commit into from
+7 −5

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen devnexen marked this pull request as ready for review July 20, 2025 11:31
@Girgias Girgias requested a review from nielsdos July 20, 2025 14:43
nielsdos
nielsdos reviewed Jul 20, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you directly assign to timeZone instead of using tmp?
In the current form, the advantage of unique_ptr is really slim

@devnexen devnexen force-pushed the intl_timezone_cxx11 branch from 4d646fa to e14fd06 Compare July 20, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos left review comments

Assignees
No one assigned
Labels
Extension: intl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @nielsdos