Remove zend_jit_vm_kind #19299
Open
Remove zend_jit_vm_kind #19299
+25
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIT used to not have a compile-time dependency on VM kind, such that a single build of opcache could work with VM kinds at runtime. This has been broken over time and would be difficult to restore. Additionally, as opcache is now built-in, this would not be useful anymore. Remove the zend_jit_vm_kind variable.
arnaud-lb
commented
Jul 30, 2025
Comment on lines
+3709
to
+3711
| #if ZEND_VM_KIND != ZEND_VM_KIND_CALL && ZEND_VM_KIND != ZEND_VM_KIND_HYBRID | ||
| # error JIT is compatible only with CALL and HYBRID VM | ||
| #endif |
There was a problem hiding this comment.
This could be a configure check, but it's difficult to determine the VM kind in configure. Also, triggering this error is only possible by manually re-generating the VM with zend_vm_gen.php --with-vm-kind=..., so it seems fine.
nielsdos
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIT used to not have a compile-time dependency on VM kind, such that a single build of opcache could work with different VM kinds at runtime. This has been broken over time and would be difficult to restore. Additionally, as opcache is now built-in, this would not be useful anymore.
Remove the zend_jit_vm_kind variable as suggested in #19006 (comment).