Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the absence of
PHP_ARG_WITH([opcache],
, the value ofext_shared
is not initialized while processing directives ofext/opcache/config.m4
, causingPHP_EVAL_LIBLINE()
to add libs toOPCACHE_SHARED_LIBADD
instead ofLIBS
.For example, running
./configure --with-dbmaker=shared --with-capstone
will setext_shared=yes
before processing opcache. In this case,-lcapstone
is added toOPCACHE_SHARED_LIBADD
.Fixing by setting
libs-variable
toLIBS
.@remicollet could you confirm this fixes the issue?