Skip to content

Fix GH-19320: FPM uid and gid overflow #19321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: PHP-8.3
Choose a base branch
from
Open

Fix GH-19320: FPM uid and gid overflow #19321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions sapi/fpm/fpm/fpm_unix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,13 @@ static int fpm_unix_conf_wp(struct fpm_worker_pool_s *wp) /* {{{ */
if (is_root) {
if (wp->config->user && *wp->config->user) {
if (fpm_unix_is_id(wp->config->user)) {
wp->set_uid = strtoul(wp->config->user, 0, 10);
unsigned long uid_val = strtoul(wp->config->user, 0, 10);
if (uid_val > INT_MAX) {
zlog(ZLOG_ERROR, "[pool %s] invalid user ID '%s': value too large",
wp->config->name, wp->config->user);
return -1;
}
wp->set_uid = (int)uid_val;
pwd = getpwuid(wp->set_uid);
if (pwd) {
wp->set_gid = pwd->pw_gid;
Expand All @@ -378,7 +384,13 @@ static int fpm_unix_conf_wp(struct fpm_worker_pool_s *wp) /* {{{ */

if (wp->config->group && *wp->config->group) {
if (fpm_unix_is_id(wp->config->group)) {
wp->set_gid = strtoul(wp->config->group, 0, 10);
unsigned long gid_val = strtoul(wp->config->group, 0, 10);
if (gid_val > INT_MAX) {
zlog(ZLOG_ERROR, "[pool %s] invalid group ID '%s': value too large",
wp->config->name, wp->config->group);
return -1;
}
wp->set_gid = (int)gid_val;
} else {
struct group *grp;

Expand Down
58 changes: 58 additions & 0 deletions sapi/fpm/tests/gh19320-user-group-overflow.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
--TEST--
FPM: gh19320 - config test UID/GID overflow validation
--SKIPIF--
<?php
include "skipif.inc";
FPM\Tester::skipIfNotRoot();
?>
--FILE--
<?php
require_once "tester.inc";

// Test with UID that exceeds INT_MAX (2147483647)
$cfg_uid = <<<EOT
[global]
error_log = {{FILE:LOG}}
[unconfined]
listen = {{ADDR:UDS}}
user = 2147483648
group = root
pm = dynamic
pm.max_children = 5
pm.start_servers = 2
pm.min_spare_servers = 1
pm.max_spare_servers = 3
EOT;

$tester = new FPM\Tester($cfg_uid);
$tester->start();
$tester->expectLogError("\[pool unconfined\] invalid user ID '2147483648': value too large");

// Test with GID that exceeds INT_MAX
$cfg_gid = <<<EOT
[global]
error_log = {{FILE:LOG}}
[unconfined]
listen = {{ADDR:UDS}}
user = root
group = 4294967295
pm = dynamic
pm.max_children = 5
pm.start_servers = 2
pm.min_spare_servers = 1
pm.max_spare_servers = 3
EOT;

$tester = new FPM\Tester($cfg_gid);
$tester->start();
$tester->expectLogError("\[pool unconfined\] invalid group ID '4294967295': value too large");
?>
Done
--EXPECT--
Done
--CLEAN--
<?php
require_once "tester.inc";
FPM\Tester::clean();
?>

Loading