Skip to content

Add print_r() to function_arguments/sensitive_parameter_value.phpt #8340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2022
Merged

Add print_r() to function_arguments/sensitive_parameter_value.phpt #8340

merged 1 commit into from
Apr 11, 2022

Conversation

TimWolla
Copy link
Member

see 9085197
see #7921

cmb69
cmb69 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! You should be able to merge this yourself. :)

@TimWolla
Copy link
Member Author

You should be able to merge this yourself. :)

Just the "Squash and merge" button, or anything special?

@cmb69
Copy link
Member

cmb69 commented Apr 11, 2022

Just the "Squash and merge" button, or anything special?

When targeting the master branch (like in this case), "squash and merge" is fine. Otherwise, see https://wiki.php.net/vcs/gitworkflow.

@TimWolla TimWolla merged commit dcd5e82 into php:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimWolla @cmb69 @iluuu1994